appengine/findit/waterfall/identify_try_job_culprit_pipeline.py - Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

diff --git a/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py b/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

index 762326aca7b097b3ee8fa7f8fc8323164411262a..8b05dabeeccc9181eb2b7da96681b235bd87a2f4 100644

--- a/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

+++ b/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

@@ -24,7 +24,7 @@ from waterfall.send_notification_for_culprit_pipeline import (

GIT_REPO = GitilesRepository(

- 'https://chromium.googlesource.com/chromium/src.git', HttpClient())

+ HttpClient(), 'https://chromium.googlesource.com/chromium/src.git')

def _GetResultAnalysisStatus(analysis, result):