Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2309)

Unified Diff: appengine/findit/waterfall/extract_deps_info_pipeline.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/extract_deps_info_pipeline.py
diff --git a/appengine/findit/waterfall/extract_deps_info_pipeline.py b/appengine/findit/waterfall/extract_deps_info_pipeline.py
index 303a2762e2326f6ef63b359afdc47a22b22689e8..f76955cec40295b9ade8adff933afc2fc8f2f25d 100644
--- a/appengine/findit/waterfall/extract_deps_info_pipeline.py
+++ b/appengine/findit/waterfall/extract_deps_info_pipeline.py
@@ -47,7 +47,7 @@ def _GetDependencies(chromium_revision, os_platform):
"""Returns the dependencies used by the specified chromium revision."""
deps = {}
dep_fetcher=chrome_dependency_fetcher.ChromeDependencyFetcher(
- gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
+ gitiles_repository.GitilesRepository(HttpClientAppengine()))
for path, dependency in dep_fetcher.GetDependency(
chromium_revision, os_platform).iteritems():
deps[path] = {
@@ -81,7 +81,7 @@ def _DetectDependencyRolls(change_logs, os_platform):
"""
deps_rolls = {}
dep_fetcher=chrome_dependency_fetcher.ChromeDependencyFetcher(
- gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
+ gitiles_repository.GitilesRepository(HttpClientAppengine()))
for revision, change_log in change_logs.iteritems():
# Check DEPS roll only if the chromium DEPS file is changed by the CL.
for touched_file in change_log['touched_files']:
« no previous file with comments | « appengine/findit/waterfall/build_failure_analysis.py ('k') | appengine/findit/waterfall/identify_try_job_culprit_pipeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698