Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2060)

Unified Diff: appengine/findit/lib/gitiles/test/gitiles_repository_test.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/lib/gitiles/test/gitiles_repository_test.py
diff --git a/appengine/findit/lib/gitiles/test/gitiles_repository_test.py b/appengine/findit/lib/gitiles/test/gitiles_repository_test.py
index 36fbbf8fb9ed5c575214a2a1ab5d4871e07d3fcf..3c4661f32a3ffa971a99e83eb06a82387d41b367 100644
--- a/appengine/findit/lib/gitiles/test/gitiles_repository_test.py
+++ b/appengine/findit/lib/gitiles/test/gitiles_repository_test.py
@@ -262,22 +262,21 @@ class GitRepositoryTest(TestCase):
self.http_client_for_git = self.GetMockHttpClient()
self.repo_url = 'https://repo.test'
self.git_repo = gitiles_repository.GitilesRepository(
- self.repo_url, self.http_client_for_git)
+ self.http_client_for_git, self.repo_url)
def testGitRepositoryPropertySetters(self):
- git_repo = gitiles_repository.GitilesRepository(
- http_client=self.http_client_for_git)
+ git_repo = gitiles_repository.GitilesRepository(self.http_client_for_git)
git_repo.repo_url = 'https://repo'
self.assertEqual(git_repo.repo_url, 'https://repo')
self.assertEqual(git_repo.http_client, self.http_client_for_git)
def testEndingSlashInRepoUrl(self):
git_repo1 = gitiles_repository.GitilesRepository(
- self.repo_url, self.http_client_for_git)
+ self.http_client_for_git, self.repo_url)
self.assertEqual(self.repo_url, git_repo1.repo_url)
git_repo2 = gitiles_repository.GitilesRepository(
- '%s/' % self.repo_url, self.http_client_for_git)
+ self.http_client_for_git, '%s/' % self.repo_url)
self.assertEqual(self.repo_url, git_repo2.repo_url)
def testMalformattedJsonReponse(self):
@@ -446,6 +445,5 @@ class GitRepositoryTest(TestCase):
def testGetWrappedGitRepositoryClass(self):
repo = gitiles_repository.GitilesRepository(
- 'http://repo_url', self.http_client_for_git)
-
+ self.http_client_for_git, 'http://repo_url')
self.assertEqual(repo.repo_url, 'http://repo_url')
« no previous file with comments | « appengine/findit/lib/gitiles/gitiles_repository.py ('k') | appengine/findit/waterfall/build_failure_analysis.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698