[Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

appengine/findit/lib/gitiles/test/gitiles_repository_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 from datetime import datetime
 import json
 import re
 
 from testing_utils import testing
@@ skipping 244 matching lines @@
 }
 
 
 class GitRepositoryTest(TestCase):
 
   def setUp(self):
     super(GitRepositoryTest, self).setUp()
     self.http_client_for_git = self.GetMockHttpClient()
     self.repo_url = 'https://repo.test'
     self.git_repo = gitiles_repository.GitilesRepository(
-        self.repo_url, self.http_client_for_git)
+        self.http_client_for_git, self.repo_url)
 
   def testGitRepositoryPropertySetters(self):
-    git_repo = gitiles_repository.GitilesRepository(
-        http_client=self.http_client_for_git)
+    git_repo = gitiles_repository.GitilesRepository(self.http_client_for_git)
     git_repo.repo_url = 'https://repo'
     self.assertEqual(git_repo.repo_url, 'https://repo')
     self.assertEqual(git_repo.http_client, self.http_client_for_git)
 
   def testEndingSlashInRepoUrl(self):
     git_repo1 = gitiles_repository.GitilesRepository(
-        self.repo_url, self.http_client_for_git)
+        self.http_client_for_git, self.repo_url)
     self.assertEqual(self.repo_url, git_repo1.repo_url)
 
     git_repo2 = gitiles_repository.GitilesRepository(
-        '%s/' % self.repo_url, self.http_client_for_git)
+        self.http_client_for_git, '%s/' % self.repo_url)
     self.assertEqual(self.repo_url, git_repo2.repo_url)
 
   def testMalformattedJsonReponse(self):
     self.http_client_for_git.SetResponseForUrl(
         '%s/+/%s?format=json' % (self.repo_url, 'aaa'), 'abcde{"a": 1}')
     self.assertRaisesRegexp(
         Exception, re.escape('Response does not begin with )]}\'\n'),
         self.git_repo.GetChangeLog, 'aaa')
 
   def testGetChangeLog(self):
@@ skipping 148 matching lines @@
 
     self.mock(gitiles_repository.GitilesRepository,
         '_SendRequestForJsonResponse', _MockSendRequestForJsonResponse)
 
     changelogs = self.git_repo.GetChangeLogs('0', '2')
 
     self.assertEqual(len(changelogs), 2)
 
   def testGetWrappedGitRepositoryClass(self):
     repo = gitiles_repository.GitilesRepository(
-        'http://repo_url', self.http_client_for_git)
-
+        self.http_client_for_git, 'http://repo_url')
     self.assertEqual(repo.repo_url, 'http://repo_url')