[Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

appengine/findit/lib/gitiles/gitiles_repository.py

Index: appengine/findit/lib/gitiles/gitiles_repository.py
diff --git a/appengine/findit/lib/gitiles/gitiles_repository.py b/appengine/findit/lib/gitiles/gitiles_repository.py
index a07b19a7bbe90bab97dcd42d25b1aabc5ae2e2c0..1dc4cb6e784c7128afe45f821859dd54980ecee1 100644
--- a/appengine/findit/lib/gitiles/gitiles_repository.py
+++ b/appengine/findit/lib/gitiles/gitiles_repository.py
@@ -33,8 +33,7 @@ CACHE_EXPIRE_TIME_SECONDS = 24 * 60 * 60
 class GitilesRepository(GitRepository):
   """Use Gitiles to access a repository on https://chromium.googlesource.com."""
 
-  # TODO(crbug.com/659449): Refactor the http_client to be required argument.
-  def __init__(self, repo_url=None, http_client=None):
+  def __init__(self, http_client, repo_url=None):

[chanli, 2016/11/23 06:06:06]

Any reason you changed the sequence of the arguments?

[Sharu Jiang, 2016/11/23 19:24:39]

Because the http_client is required arguments now, it should be before the
optional argument.

     super(GitilesRepository, self).__init__()
     if repo_url and repo_url.endswith('/'):
       self._repo_url = repo_url[:-1]