[Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

appengine/findit/lib/gitiles/gitiles_repository.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 from datetime import datetime
 from datetime import timedelta
 import json
 import re
 
@@ skipping 15 matching lines @@
     '^(?:Review URL|Review-Url): (.*\d+).*$', re.IGNORECASE)
 REVERTED_REVISION_PATTERN = re.compile(
     '^> Committed: https://.+/([0-9a-fA-F]{40})$', re.IGNORECASE)
 TIMEZONE_PATTERN = re.compile('[-+]\d{4}$')
 CACHE_EXPIRE_TIME_SECONDS = 24 * 60 * 60
 
 
 class GitilesRepository(GitRepository):
   """Use Gitiles to access a repository on https://chromium.googlesource.com."""
 
-  # TODO(crbug.com/659449): Refactor the http_client to be required argument.
-  def __init__(self, repo_url=None, http_client=None):
+  def __init__(self, http_client, repo_url=None):

[chanli, 2016/11/23 06:06:06]

Any reason you changed the sequence of the arguments?

[Sharu Jiang, 2016/11/23 19:24:39]

Because the http_client is required arguments now, it should be before the
optional argument.

     super(GitilesRepository, self).__init__()
     if repo_url and repo_url.endswith('/'):
       self._repo_url = repo_url[:-1]
     else:
       self._repo_url = repo_url
 
     self._http_client = http_client
 
   @property
   def repo_url(self):
@@ skipping 174 matching lines @@
 
       for log in data['log']:
         changelogs.append(self._ParseChangeLogFromLogData(log))
 
       if 'next' in data:
         next_end_revision = data['next']
       else:
         next_end_revision = None
 
     return changelogs