[Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

appengine/findit/crash/test/changelist_classifier_test.py

Index: appengine/findit/crash/test/changelist_classifier_test.py
diff --git a/appengine/findit/crash/test/changelist_classifier_test.py b/appengine/findit/crash/test/changelist_classifier_test.py
index 77c37aa7aa4d0dc4d05e54ed209e835134ea21af..42c6550c3a43d464d69210892b741c76688299ca 100644
--- a/appengine/findit/crash/test/changelist_classifier_test.py
+++ b/appengine/findit/crash/test/changelist_classifier_test.py
@@ -133,7 +133,7 @@ class ChangelistClassifierTest(CrashTestSuite):
     self.mock(changelist_classifier, 'FindMatchResults', lambda *_: None)
 
     cl_classifier = changelist_classifier.ChangelistClassifier(
-        GitilesRepository(), 7)
+        GitilesRepository(self.GetMockHttpClient()), 7)
     cl_classifier(CrashReport(crashed_version = '5',
                               signature = 'sig',
                               platform = 'canary',
@@ -187,7 +187,8 @@ class ChangelistClassifierTest(CrashTestSuite):
 
     dep_file_to_changelogs, ignore_cls = (
         changelist_classifier.GetChangeLogsForFilesGroupedByDeps(
-            regression_deps_rolls, stack_deps, GitilesRepository()))
+            regression_deps_rolls, stack_deps,
+            GitilesRepository(self.GetMockHttpClient())))
     dep_file_to_changelogs_json = defaultdict(lambda: defaultdict(list))
     for dep, file_to_changelogs in dep_file_to_changelogs.iteritems():
       for file_path, changelogs in file_to_changelogs.iteritems():
@@ -299,7 +300,7 @@ class ChangelistClassifierTest(CrashTestSuite):
 
     match_results = changelist_classifier.FindMatchResults(
         dep_file_to_changelogs, dep_file_to_stack_infos, stack_deps,
-        GitilesRepository())
+        GitilesRepository(self.GetMockHttpClient()))
     self.assertListEqual([result.ToDict() for result in match_results],
                          expected_match_results)
 
@@ -310,8 +311,8 @@ class ChangelistClassifierTest(CrashTestSuite):
         'GetDependencyRollsDict', lambda *_: {})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
-    cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        GitilesRepository())
+    cl_classifier = changelist_classifier.ChangelistClassifier(
+        7, GitilesRepository(self.GetMockHttpClient()))

[wrengr, 2016/11/22 19:11:53]

Since we do this line a lot in a bunch of tests, maybe we should just have a
self.GetChangelistClassifier() method

[Sharu Jiang, 2016/11/22 20:15:38]

Done.

     # N.B., for this one test we really do want regression_range=None.
     report = DUMMY_REPORT._replace(regression_range=None)
     self.assertListEqual(cl_classifier(report), [])
@@ -323,8 +324,8 @@ class ChangelistClassifierTest(CrashTestSuite):
         lambda *_: {'src/': DependencyRoll('src/', 'https://repo', '1', '2')})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
-    cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        GitilesRepository())
+    cl_classifier = changelist_classifier.ChangelistClassifier(
+        7, GitilesRepository(self.GetMockHttpClient()))
     self.assertListEqual(cl_classifier(DUMMY_REPORT), [])
 
   def testFindItForCrash(self):
@@ -357,8 +358,8 @@ class ChangelistClassifierTest(CrashTestSuite):
         lambda *_: {'src/': DependencyRoll('src/', 'https://repo', '1', '2')})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
-    cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        GitilesRepository())
+    cl_classifier = changelist_classifier.ChangelistClassifier(
+        7, GitilesRepository(self.GetMockHttpClient()))
     results = cl_classifier(DUMMY_REPORT)
     expected_match_results = [
         {
@@ -416,8 +417,8 @@ class ChangelistClassifierTest(CrashTestSuite):
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
 
-    cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        GitilesRepository())
+    cl_classifier = changelist_classifier.ChangelistClassifier(
+        7, GitilesRepository(self.GetMockHttpClient()))
     results = cl_classifier(DUMMY_REPORT)
     expected_match_results = [
         {
@@ -475,6 +476,6 @@ class ChangelistClassifierTest(CrashTestSuite):
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
 
-    cl_classifier = changelist_classifier.ChangelistClassifier(7,
-        GitilesRepository())
+    cl_classifier = changelist_classifier.ChangelistClassifier(
+        7, GitilesRepository(self.GetMockHttpClient()))
     self.assertListEqual(cl_classifier(DUMMY_REPORT), [])