Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 252443006: Never throttle unconsumed touchmove acks (Closed)

Created:
6 years, 8 months ago by jdduke (slow)
Modified:
6 years, 8 months ago
Reviewers:
brianderson, piman
CC:
chromium-reviews, darin-cc_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Never throttle unconsumed touchmove acks Throttling unconsumed touchmove's (particularly the first touchmove) when the main thread is heavy blocks accelerated scrolling. This is most evident during page load, when the accelerated path is the only viable path for fluid touch interaction. Address this by completely disabling RenderWidget ack throttling for unconsumed touchmoves. BUG=366765 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266114

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/render_widget.cc View 1 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
jdduke (slow)
brianderson@: PTAL per offline discussion. I think it's OK to treat touchmove's special here, as ...
6 years, 8 months ago (2014-04-24 19:11:39 UTC) #1
jdduke (slow)
https://codereview.chromium.org/252443006/diff/20001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/252443006/diff/20001/content/renderer/render_widget.cc#newcode1062 content/renderer/render_widget.cc:1062: ack_result == INPUT_EVENT_ACK_STATE_CONSUMED); Alternatively, we can move the |CONSUMED| ...
6 years, 8 months ago (2014-04-24 19:12:59 UTC) #2
piman
lgtm
6 years, 8 months ago (2014-04-24 19:30:36 UTC) #3
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-24 21:24:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/252443006/20001
6 years, 8 months ago (2014-04-24 21:44:14 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 03:17:23 UTC) #6
Message was sent while issue was closed.
Change committed as 266114

Powered by Google App Engine
This is Rietveld 408576698