content/renderer/render_widget.cc - Issue 252443006: Never throttle unconsumed touchmove acks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_widget.cc

Issue 252443006: Never throttle unconsumed touchmove acks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_widget.cc

diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc

index 4ab9a5e5cd6b980a9da341c09bfb6ced9c65898b..42f1ce6260afa90114a48bb9b4a63c4b8eb94970 100644

--- a/content/renderer/render_widget.cc

+++ b/content/renderer/render_widget.cc

@@ -1053,10 +1053,13 @@ void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,

}

+ // Unconsumed touchmove acks should never be throttled as they're required to

+ // dispatch compositor-handled scroll gestures.

bool event_type_can_be_rate_limited =

input_event->type == WebInputEvent::MouseMove ||

input_event->type == WebInputEvent::MouseWheel ||

- input_event->type == WebInputEvent::TouchMove;

+ (input_event->type == WebInputEvent::TouchMove &&

+ ack_result == INPUT_EVENT_ACK_STATE_CONSUMED);

jdduke (slow) 2014/04/24 19:12:59 Alternatively, we can move the |CONSUMED| check be

bool frame_pending = has_frame_pending_;

if (is_accelerated_compositing_active_) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »