Chromium Code Reviews| Index: ios/chrome/browser/find_in_page/js_findinpage_manager.mm |
| diff --git a/ios/chrome/browser/find_in_page/js_findinpage_manager.mm b/ios/chrome/browser/find_in_page/js_findinpage_manager.mm |
| index d79c5034dec6cd615b6a9f80b36ec868f38c2110..0036987fe52407eb3059be24dd198ad146f72faf 100644 |
| --- a/ios/chrome/browser/find_in_page/js_findinpage_manager.mm |
| +++ b/ios/chrome/browser/find_in_page/js_findinpage_manager.mm |
| @@ -16,6 +16,10 @@ |
| #include "base/values.h" |
| #import "ios/chrome/browser/find_in_page/find_in_page_model.h" |
| +#if !defined(__has_feature) || !__has_feature(objc_arc) |
| +#error "This file requires ARC support." |
| +#endif |
| + |
| namespace { |
| // Initializes Find In Page JavaScript with the width and height of the window. |
| @@ -137,7 +141,7 @@ const FindInPageEntry kFindInPageEntryZero = {{0.0, 0.0}, 0}; |
| base::WeakNSObject<JsFindinpageManager> weakSelf(self); |
| [self executeJavaScript:script |
| completionHandler:^(id result, NSError* error) { |
| - base::WeakNSObject<JsFindinpageManager> strongSelf([weakSelf retain]); |
|
noyau (Ping after 24h)
2016/11/25 10:27:46
Hu? A supposed "strongSelf" stored in a Weak? This
stkhapugin
2016/11/25 11:23:04
This is the coolest catch!
|
| + base::WeakNSObject<JsFindinpageManager> strongSelf(weakSelf); |
| if (!strongSelf) |
| return; |
| DCHECK(!error); |