Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2524333003: Clamp scroll offset after overflow reclacs that are not layout inducing (Closed)

Created:
4 years ago by majidvp
Modified:
4 years ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp scroll offset after overflow reclacs that are not layout inducing Changes in overflow content size and clip should trigger a re-clamping of the scroll offset even if the change is not layout inducing (e.g., transform) BUG=652092 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/79f6f52c6732cd3082a9984329245b41c8c92a42 Cr-Commit-Position: refs/heads/master@{#434679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/overflow/overflow-clamp-after-transform-related-content-size-change.html View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
majidvp
4 years ago (2016-11-24 18:13:45 UTC) #5
skobes
lgtm
4 years ago (2016-11-25 16:33:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524333003/1
4 years ago (2016-11-28 15:24:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 17:39:20 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 17:43:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79f6f52c6732cd3082a9984329245b41c8c92a42
Cr-Commit-Position: refs/heads/master@{#434679}

Powered by Google App Engine
This is Rietveld 408576698