Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2524333003: Clamp scroll offset after overflow reclacs that are not layout inducing (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 313
314 // This will set the scroll position without clamping, and it will do all 314 // This will set the scroll position without clamping, and it will do all
315 // post-update work even if the scroll position didn't change. 315 // post-update work even if the scroll position didn't change.
316 void setScrollPositionUnconditionally(const DoublePoint&, 316 void setScrollPositionUnconditionally(const DoublePoint&,
317 ScrollType = ProgrammaticScroll); 317 ScrollType = ProgrammaticScroll);
318 318
319 // TODO(szager): Actually run these after all of layout is finished. 319 // TODO(szager): Actually run these after all of layout is finished.
320 // Currently, they run at the end of box()'es layout (or after all flexbox 320 // Currently, they run at the end of box()'es layout (or after all flexbox
321 // layout has finished) but while document layout is still happening. 321 // layout has finished) but while document layout is still happening.
322 void updateAfterLayout(); 322 void updateAfterLayout();
323 void clampScrollOffsetsAfterLayout(); 323 void clampScrollOffsetAfterOverflowChange();
324 324
325 void didChangeGlobalRootScroller() override; 325 void didChangeGlobalRootScroller() override;
326 326
327 void updateAfterStyleChange(const ComputedStyle*); 327 void updateAfterStyleChange(const ComputedStyle*);
328 void updateAfterOverflowRecalc(); 328 void updateAfterOverflowRecalc();
329 329
330 bool updateAfterCompositingChange() override; 330 bool updateAfterCompositingChange() override;
331 331
332 bool hasScrollbar() const { 332 bool hasScrollbar() const {
333 return hasHorizontalScrollbar() || hasVerticalScrollbar(); 333 return hasHorizontalScrollbar() || hasVerticalScrollbar();
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 585
586 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, 586 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,
587 ScrollableArea, 587 ScrollableArea,
588 scrollableArea, 588 scrollableArea,
589 scrollableArea->isPaintLayerScrollableArea(), 589 scrollableArea->isPaintLayerScrollableArea(),
590 scrollableArea.isPaintLayerScrollableArea()); 590 scrollableArea.isPaintLayerScrollableArea());
591 591
592 } // namespace blink 592 } // namespace blink
593 593
594 #endif // LayerScrollableArea_h 594 #endif // LayerScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698