Parser: Introduce StatementList + NewStatementList()

Parser: Introduce StatementList + NewStatementList()

Adds new Traits::Type::StatementList definitions both for Parser and
PreParser, and the corresponding NewStatementList() factory function.
This is needed to be able to define in ParserBase parsing functions
that return and manipulate lists of statements.

Moving and renaming PreParser::Statement to PreParserStatement is also
needed so its definition is available earlier for PreParserStatementList
to use it.

R=marja@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20965

[aperez, 2014-04-24 15:28:23]

Those changes would be needed to implement arrow function parsing, and merged
before https://codereview.chromium.org/160073006/

[marja, 2014-04-24 15:31:09]

https://codereview.chromium.org/252423007/diff/1/src/preparser.cc
File src/preparser.cc (right):

https://codereview.chromium.org/252423007/diff/1/src/preparser.cc#newcode186
src/preparser.cc:186: PreParserStatement PreParser::ParseSourceElement(bool* ok)
{
The same here.

https://codereview.chromium.org/252423007/diff/1/src/preparser.cc#newcode220
src/preparser.cc:220: PreParserStatement statement =
ParseSourceElement(CHECK_OK);
... and overall.

https://codereview.chromium.org/252423007/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/252423007/diff/1/src/preparser.h#newcode1098
src/preparser.h:1098: 
Add a typedef for Statement here...

https://codereview.chromium.org/252423007/diff/1/src/preparser.h#newcode1164
src/preparser.h:1164: // All ParseXXX functions take as the last argument an *ok
parameter
So you don't need to change these lines.

[aperez, 2014-04-24 16:53:37]

On 2014/04/24 15:31:09, marja wrote:
> https://codereview.chromium.org/252423007/diff/1/src/preparser.cc
> File src/preparser.cc (right):
> 
> [...]

The new version of the patches adds a PreParser::Statement typedef
and reverts most of the PreParser::Statement → PreParserStatement
changes, as suggested.

[marja, 2014-04-24 19:22:08]

lgtm. Do you need somebody to land this or are you a committer?

[aperez, 2014-04-24 19:45:38]

The CQ bit was checked by aperez@igalia.com

[commit-bot: I haz the power, 2014-04-24 19:46:01]

CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/aperez@igalia.com/252423007/20001

[commit-bot: I haz the power, 2014-04-24 19:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 19:46:03]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[aperez, 2014-04-24 19:48:10]

On 2014/04/24 19:22:08, marja wrote:
> lgtm. Do you need somebody to land this or are you a committer?

I am not a committer (yet). I have enabled the commit-queue flag to get it
landed. If that does not work out, a committer would need to land the patch
manually.

[aperez, 2014-04-24 19:50:20]

On 2014/04/24 19:46:03, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet [...]

Ouch, it seems we will need a bit of help here :-)

[marja, 2014-04-25 06:31:38]

I didn't know V8 had a commit queue! (The last time I heard, we didn't.) Also,
afaik, V8 doesn't differentiate between full and provisional committers like
Chromium. I'm listed in the OWNERS file, not sure what other superpowers would
be required. :) I'll try to land this later today, let's see if it works.

[marja, 2014-04-25 09:44:35]

Committed patchset #2 manually as r20965 (presubmit successful).

[marja, 2014-04-25 09:45:07]

On 2014/04/25 09:44:35, marja wrote:
> Committed patchset #2 manually as r20965 (presubmit successful).

Alright, that worked. The commit queue just doesn't know how to. (I don't think
it's supposed to work yet.)

[aperez, 2014-04-25 10:08:51]

On 2014/04/25 09:45:07, marja wrote:
> On 2014/04/25 09:44:35, marja wrote:
> > Committed patchset #2 manually as r20965 (presubmit successful).
> 
> Alright, that worked. The commit queue just doesn't know how to. (I don't
think
> it's supposed to work yet.)

Somehow I thought the CQ was working… anyway, thanks again!