MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews.

MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews.

The "Harmony" control style diverges sufficiently from AppKit controls
such that we should no longer distinguish between "WebUI" and "AppKit"
themes for native dialogs when selecting whether to use the
toolkit-views or Cocoa version of a dialog.

Also the toolkit-views theme currently breaks on Mac when not used in
conjunction with --secondary-ui-md.

--secondary-ui-md describes the outcome nicely, so collapse the
"MacViewsNativeDialogs" and "MacViewsWebUIDialogs" feature flags into
--secondary-ui-md.

BUG=658105
Committed: https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9
Cr-Commit-Position: refs/heads/master@{#435575}

[tapted, 2016-11-24 00:08:57]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 00:09:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-11-24 00:16:01]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 00:16:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-11-24 00:24:16]

Description was changed from

==========
MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews.



BUG=658105
==========

to

==========
MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews.

The "Harmony" control style diverges sufficiently from AppKit controls
such that we should no longer distinguish between "WebUI" and "AppKit"
themes for native dialogs when selecting whether to use the
toolkit-views or Cocoa version of a dialog.

Also the toolkit-views theme currently breaks on Mac when not used in
conjunction with --secondary-ui-md.

--secondary-ui-md describes the outcome nicely, so collapse the
"MacViewsNativeDialogs" and "MacViewsWebUIDialogs" feature flags into
--secondary-ui-md.

BUG=658105
==========

[tapted, 2016-11-24 00:24:16]

tapted@chromium.org changed reviewers:
+ ellyjones@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:19:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:19:07]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[tapted, 2016-11-25 00:56:08]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 00:56:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 01:38:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 01:38:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2016-11-25 02:54:02]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 02:54:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 03:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 03:55:08]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-11-28 07:45:51]

Hi Elly - wdyt?

https://codereview.chromium.org/2524213002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/browser_dialogs_views_mac.cc (left):

https://codereview.chromium.org/2524213002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/browser_dialogs_views_mac.cc:64: // on Mac also means
the Views task manager is desired.
(this comment became obsolete in r409593 "The "new" Views Task Manager is the
only one." but is was reworded instead -- s/new/Views/)

[tapted, 2016-11-29 03:45:38]

tapted@chromium.org changed reviewers:
+ karandeepb@chromium.org

[tapted, 2016-11-29 03:45:39]

+karan maybe you can do a sanity check before I send to OWNERS - Thanks!

[karandeepb, 2016-11-29 05:00:25]

lgtm

[tapted, 2016-11-29 05:01:58]

tapted@chromium.org changed reviewers:
+ msw@chromium.org

[tapted, 2016-11-29 05:02:42]

tapted@chromium.org changed reviewers:
- ellyjones@chromium.org

[tapted, 2016-11-29 05:02:42]

+msw for chrome/browser/ui/OWNERS - thanks!

[msw, 2016-11-29 18:46:33]

msw@chromium.org changed reviewers:
+ estade@chromium.org

[msw, 2016-11-29 18:46:34]

+Evan as 'owner' of --secondary-ui-md. Does continued use of this flag for Mac
Views make sense as your work progresses (and completes) on non-Mac platforms?

[tapted, 2016-11-30 21:32:32]

estade: ping?

[Evan Stade, 2016-11-30 23:36:47]

On 2016/11/30 21:32:32, tapted wrote:
> estade: ping?

Sorry. Is there a particular file you'd like me to look at? Since I've been
working on other things besides Harmony, maybe Elly is more up to date on the
state of the project (I see you already cc'd her), and can comment on why
non-harmony macviews is broken or if we care. But my understanding is that there
will be no launch of mac views without also using Harmony, so broadly speaking
it seems fine to merge the flags.

[tapted, 2016-11-30 23:38:25]

On 2016/11/30 23:36:47, Evan Stade wrote:
> On 2016/11/30 21:32:32, tapted wrote:
> > estade: ping?
> 
> Sorry. Is there a particular file you'd like me to look at? Since I've been
> working on other things besides Harmony, maybe Elly is more up to date on the
> state of the project (I see you already cc'd her), and can comment on why
> non-harmony macviews is broken or if we care. But my understanding is that
there
> will be no launch of mac views without also using Harmony, so broadly speaking
> it seems fine to merge the flags.

no particular file - just for msw's comment above:

On 2016/11/29 18:46:34, msw wrote:
> +Evan as 'owner' of --secondary-ui-md. Does continued use of this flag for Mac
> Views make sense as your work progresses (and completes) on non-Mac platforms?

which I think you've answered with "it seems fine to merge the flags" :)

[msw, 2016-12-01 02:00:04]

I still think it's a bit odd, since secondary-ui-md might want to default-on for
Win/Linux/Cros separately from launching these views dialogs on Mac, but if Evan
thinks it's alright, then lgtm, I guess.

[tapted, 2016-12-01 02:05:53]

On 2016/12/01 02:00:04, msw wrote:
> I still think it's a bit odd, since secondary-ui-md might want to default-on
for
> Win/Linux/Cros separately from launching these views dialogs on Mac, but if
Evan
> thinks it's alright, then lgtm, I guess.

Yeah - a per-platform bring-up is likely. I don't think this will get in the way
though. And I think there's an upside to having the flag behave the same on all
platforms without having to faff around with other flags.

[tapted, 2016-12-01 02:06:12]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-12-01 02:06:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 02:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 02:09:58]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tapted, 2016-12-01 05:42:05]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 05:42:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 06:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 06:41:14]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-12-01 07:34:33]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-12-01 07:34:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
karandeepb@chromium.org, msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2524213002/#ps80001
(title: "rebase for r435075")

[commit-bot: I haz the power, 2016-12-01 07:34:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 07:39:08]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480577673856810,
"parent_rev": "d2591d7b48069be224346f40cb25573e24135701", "commit_rev":
"968c75ef5bfd07b7e2b9898cd543f48d3bd57605"}

[commit-bot: I haz the power, 2016-12-01 07:39:39]

Description was changed from

==========
MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews.

The "Harmony" control style diverges sufficiently from AppKit controls
such that we should no longer distinguish between "WebUI" and "AppKit"
themes for native dialogs when selecting whether to use the
toolkit-views or Cocoa version of a dialog.

Also the toolkit-views theme currently breaks on Mac when not used in
conjunction with --secondary-ui-md.

--secondary-ui-md describes the outcome nicely, so collapse the
"MacViewsNativeDialogs" and "MacViewsWebUIDialogs" feature flags into
--secondary-ui-md.

BUG=658105
==========

to

==========
MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews.

The "Harmony" control style diverges sufficiently from AppKit controls
such that we should no longer distinguish between "WebUI" and "AppKit"
themes for native dialogs when selecting whether to use the
toolkit-views or Cocoa version of a dialog.

Also the toolkit-views theme currently breaks on Mac when not used in
conjunction with --secondary-ui-md.

--secondary-ui-md describes the outcome nicely, so collapse the
"MacViewsNativeDialogs" and "MacViewsWebUIDialogs" feature flags into
--secondary-ui-md.

BUG=658105
==========

[commit-bot: I haz the power, 2016-12-01 07:39:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-01 07:41:53]

Description was changed from

==========
MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews.

The "Harmony" control style diverges sufficiently from AppKit controls
such that we should no longer distinguish between "WebUI" and "AppKit"
themes for native dialogs when selecting whether to use the
toolkit-views or Cocoa version of a dialog.

Also the toolkit-views theme currently breaks on Mac when not used in
conjunction with --secondary-ui-md.

--secondary-ui-md describes the outcome nicely, so collapse the
"MacViewsNativeDialogs" and "MacViewsWebUIDialogs" feature flags into
--secondary-ui-md.

BUG=658105
==========

to

==========
MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews.

The "Harmony" control style diverges sufficiently from AppKit controls
such that we should no longer distinguish between "WebUI" and "AppKit"
themes for native dialogs when selecting whether to use the
toolkit-views or Cocoa version of a dialog.

Also the toolkit-views theme currently breaks on Mac when not used in
conjunction with --secondary-ui-md.

--secondary-ui-md describes the outcome nicely, so collapse the
"MacViewsNativeDialogs" and "MacViewsWebUIDialogs" feature flags into
--secondary-ui-md.

BUG=658105

Committed: https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9
Cr-Commit-Position: refs/heads/master@{#435575}
==========

[commit-bot: I haz the power, 2016-12-01 07:41:54]

Patchset 5 (id:??) landed as
https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9
Cr-Commit-Position: refs/heads/master@{#435575}