Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm

Issue 2524213002: MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews. (Closed)
Patch Set: rebase for r435075 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h" 5 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
11 #include "chrome/browser/chooser_controller/chooser_controller.h" 11 #include "chrome/browser/chooser_controller/chooser_controller.h"
12 #include "chrome/browser/extensions/api/chrome_device_permissions_prompt.h" 12 #include "chrome/browser/extensions/api/chrome_device_permissions_prompt.h"
13 #include "chrome/browser/extensions/chrome_extension_chooser_dialog.h" 13 #include "chrome/browser/extensions/chrome_extension_chooser_dialog.h"
14 #include "chrome/browser/extensions/device_permissions_dialog_controller.h" 14 #include "chrome/browser/extensions/device_permissions_dialog_controller.h"
15 #include "chrome/browser/ui/browser_dialogs.h"
16 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sh eet.h" 15 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sh eet.h"
17 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_wi ndow.h" 16 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_wi ndow.h"
18 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h" 17 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h"
19 #include "components/web_modal/web_contents_modal_dialog_manager.h" 18 #include "components/web_modal/web_contents_modal_dialog_manager.h"
19 #include "ui/base/material_design/material_design_controller.h"
20 20
21 ChooserDialogCocoa::ChooserDialogCocoa( 21 ChooserDialogCocoa::ChooserDialogCocoa(
22 content::WebContents* web_contents, 22 content::WebContents* web_contents,
23 std::unique_ptr<ChooserController> chooser_controller) 23 std::unique_ptr<ChooserController> chooser_controller)
24 : web_contents_(web_contents) { 24 : web_contents_(web_contents) {
25 DCHECK(web_contents_); 25 DCHECK(web_contents_);
26 DCHECK(chooser_controller); 26 DCHECK(chooser_controller);
27 chooser_dialog_cocoa_controller_.reset([[ChooserDialogCocoaController alloc] 27 chooser_dialog_cocoa_controller_.reset([[ChooserDialogCocoaController alloc]
28 initWithChooserDialogCocoa:this 28 initWithChooserDialogCocoa:this
29 chooserController:std::move(chooser_controller)]); 29 chooserController:std::move(chooser_controller)]);
(...skipping 16 matching lines...) Expand all
46 CreateAndShowWebModalDialogMac(this, web_contents_, sheet); 46 CreateAndShowWebModalDialogMac(this, web_contents_, sheet);
47 } 47 }
48 48
49 void ChooserDialogCocoa::Dismissed() { 49 void ChooserDialogCocoa::Dismissed() {
50 if (constrained_window_) 50 if (constrained_window_)
51 constrained_window_->CloseWebContentsModalDialog(); 51 constrained_window_->CloseWebContentsModalDialog();
52 } 52 }
53 53
54 void ChromeExtensionChooserDialog::ShowDialog( 54 void ChromeExtensionChooserDialog::ShowDialog(
55 std::unique_ptr<ChooserController> chooser_controller) const { 55 std::unique_ptr<ChooserController> chooser_controller) const {
56 if (chrome::ToolkitViewsWebUIDialogsEnabled()) 56 if (ui::MaterialDesignController::IsSecondaryUiMaterial()) {
57 return ChromeExtensionChooserDialog::ShowDialogImpl( 57 return ChromeExtensionChooserDialog::ShowDialogImpl(
58 std::move(chooser_controller)); 58 std::move(chooser_controller));
59 }
59 60
60 web_modal::WebContentsModalDialogManager* manager = 61 web_modal::WebContentsModalDialogManager* manager =
61 web_modal::WebContentsModalDialogManager::FromWebContents(web_contents_); 62 web_modal::WebContentsModalDialogManager::FromWebContents(web_contents_);
62 if (manager) { 63 if (manager) {
63 // These objects will delete themselves when the dialog closes. 64 // These objects will delete themselves when the dialog closes.
64 ChooserDialogCocoa* chooser_dialog = 65 ChooserDialogCocoa* chooser_dialog =
65 new ChooserDialogCocoa(web_contents_, std::move(chooser_controller)); 66 new ChooserDialogCocoa(web_contents_, std::move(chooser_controller));
66 chooser_dialog->ShowDialog(); 67 chooser_dialog->ShowDialog();
67 } 68 }
68 } 69 }
69 70
70 void ChromeDevicePermissionsPrompt::ShowDialog() { 71 void ChromeDevicePermissionsPrompt::ShowDialog() {
71 if (chrome::ToolkitViewsWebUIDialogsEnabled()) 72 if (ui::MaterialDesignController::IsSecondaryUiMaterial())
72 return ChromeDevicePermissionsPrompt::ShowDialogViews(); 73 return ChromeDevicePermissionsPrompt::ShowDialogViews();
73 74
74 std::unique_ptr<ChooserController> chooser_controller( 75 std::unique_ptr<ChooserController> chooser_controller(
75 new DevicePermissionsDialogController(web_contents()->GetMainFrame(), 76 new DevicePermissionsDialogController(web_contents()->GetMainFrame(),
76 prompt())); 77 prompt()));
77 78
78 // These objects will delete themselves when the dialog closes. 79 // These objects will delete themselves when the dialog closes.
79 ChooserDialogCocoa* chooser_dialog = 80 ChooserDialogCocoa* chooser_dialog =
80 new ChooserDialogCocoa(web_contents(), std::move(chooser_controller)); 81 new ChooserDialogCocoa(web_contents(), std::move(chooser_controller));
81 chooser_dialog->ShowDialog(); 82 chooser_dialog->ShowDialog();
82 } 83 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698