Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2524193002:
clang/win/x64: Fix official build after https://codereview.chromium.org/2512783005 (Closed)
Descriptionclang/win/x64: Fix official build after https://codereview.chromium.org/2512783005
C:\b\c\b\ClangToTWin64\src\chrome\browser\component_updater\swiftshader_component_installer.cc(240,6):
error: unused function 'RegisterSwiftShaderPath' [-Werror,-Wunused-function]
void RegisterSwiftShaderPath(ComponentUpdateService* cus) {
^
1 error generated.
BUG=666723
TBR=sdefresne@chromium.org
NOTRY=true
Committed: https://crrev.com/96444691f5a406941efad004b285eb59ef755731
Cr-Commit-Position: refs/heads/master@{#434315}
Patch Set 1 #
Messages
Total messages: 29 (15 generated)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
Description was changed from ========== clang/win/x64: Fix official build after https://codereview.chromium.org/2512783005 C:\b\c\b\ClangToTWin64\src\chrome\browser\component_updater\swiftshader_component_installer.cc(240,6): error: unused function 'RegisterSwiftShaderPath' [-Werror,-Wunused-function] void RegisterSwiftShaderPath(ComponentUpdateService* cus) { ^ 1 error generated. BUG=666723 TBR=sdefresne@chromium.org ========== to ========== clang/win/x64: Fix official build after https://codereview.chromium.org/2512783005 C:\b\c\b\ClangToTWin64\src\chrome\browser\component_updater\swiftshader_component_installer.cc(240,6): error: unused function 'RegisterSwiftShaderPath' [-Werror,-Wunused-function] void RegisterSwiftShaderPath(ComponentUpdateService* cus) { ^ 1 error generated. BUG=666723 TBR=sdefresne@chromium.org NOTRY=true ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
lgtm (thank you for not reverting my CL)
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479985088326500, "parent_rev":
"90a2fa278e2ef12ac1178a835cb9fe6b19e3dc46", "commit_rev":
"a006185a7f6acb1fa7b0b55bb2bbbfa7097a08a8"}
Message was sent while issue was closed.
Description was changed from ========== clang/win/x64: Fix official build after https://codereview.chromium.org/2512783005 C:\b\c\b\ClangToTWin64\src\chrome\browser\component_updater\swiftshader_component_installer.cc(240,6): error: unused function 'RegisterSwiftShaderPath' [-Werror,-Wunused-function] void RegisterSwiftShaderPath(ComponentUpdateService* cus) { ^ 1 error generated. BUG=666723 TBR=sdefresne@chromium.org NOTRY=true ========== to ========== clang/win/x64: Fix official build after https://codereview.chromium.org/2512783005 C:\b\c\b\ClangToTWin64\src\chrome\browser\component_updater\swiftshader_component_installer.cc(240,6): error: unused function 'RegisterSwiftShaderPath' [-Werror,-Wunused-function] void RegisterSwiftShaderPath(ComponentUpdateService* cus) { ^ 1 error generated. BUG=666723 TBR=sdefresne@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== clang/win/x64: Fix official build after https://codereview.chromium.org/2512783005 C:\b\c\b\ClangToTWin64\src\chrome\browser\component_updater\swiftshader_component_installer.cc(240,6): error: unused function 'RegisterSwiftShaderPath' [-Werror,-Wunused-function] void RegisterSwiftShaderPath(ComponentUpdateService* cus) { ^ 1 error generated. BUG=666723 TBR=sdefresne@chromium.org NOTRY=true ========== to ========== clang/win/x64: Fix official build after https://codereview.chromium.org/2512783005 C:\b\c\b\ClangToTWin64\src\chrome\browser\component_updater\swiftshader_component_installer.cc(240,6): error: unused function 'RegisterSwiftShaderPath' [-Werror,-Wunused-function] void RegisterSwiftShaderPath(ComponentUpdateService* cus) { ^ 1 error generated. BUG=666723 TBR=sdefresne@chromium.org NOTRY=true Committed: https://crrev.com/96444691f5a406941efad004b285eb59ef755731 Cr-Commit-Position: refs/heads/master@{#434315} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/96444691f5a406941efad004b285eb59ef755731 Cr-Commit-Position: refs/heads/master@{#434315} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
