Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2512783005: Fix //third_party/cec to not disable -Wunused-function. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix //third_party/cec to not disable -Wunused-function. Move the -Wno-unused-function to a private config that is not exported via public_configs to avoid disabling the corresponding warning for all targets depending on //base/test:test_support (//third_party/cec is a public_deps of //base/test:test_support). BUG=666723 Committed: https://crrev.com/bfd9c73b16d0bdb92ab04b1d5606fe82fe5fdac2 Cr-Commit-Position: refs/heads/master@{#434180}

Patch Set 1 #

Patch Set 2 : Fix some compilation failures. #

Patch Set 3 : Fix more compilation failures. #

Patch Set 4 : Fix even more compilation failures. #

Patch Set 5 : Rebase & fix still more compilation failures. #

Patch Set 6 : Mark LoadKeysFromTaskRunner inline to fix compilation error on win_clang bot. #

Patch Set 7 : Rebase #

Patch Set 8 : Another fix for win_clang bot #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -57 lines) Patch
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/test/base/tracing_browsertest.cc View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download
M components/leveldb_proto/proto_database_impl.h View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M components/search_engines/template_url_prepopulate_data.cc View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/ced/BUILD.gn View 3 chunks +14 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client_unittest.cc View 1 2 3 4 5 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 39 (32 generated)
sdefresne
Please take a look.
4 years, 1 month ago (2016-11-21 14:59:11 UTC) #22
brettw
lgtm
4 years, 1 month ago (2016-11-21 16:31:59 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512783005/160001
4 years ago (2016-11-23 09:27:33 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/337597)
4 years ago (2016-11-23 12:40:01 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512783005/160001
4 years ago (2016-11-23 15:14:53 UTC) #35
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years ago (2016-11-23 16:34:42 UTC) #37
commit-bot: I haz the power
4 years ago (2016-11-23 16:37:22 UTC) #39
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/bfd9c73b16d0bdb92ab04b1d5606fe82fe5fdac2
Cr-Commit-Position: refs/heads/master@{#434180}

Powered by Google App Engine
This is Rietveld 408576698