Fix SVG vertical text layout issues

Fix SVG vertical text layout issues

We layout SVG text fragments in physical coordinates of SVG <text>.
SVG text layout objects inherite from HTML text layout objects.
Previously we saved the physical coordinates in the HTML layout
objects as logical coordinates, and tried to override the HTML code
with SVG specific code to interprete the logical coordinates as
physical coordinates in painting and hittesting, etc. However, there
are still HTML code use the coordinates as logical and break some
cases.

Now convert the physical coordinates into appropriate coordinates
required by the HTML layout objects before saving them. Also let SVG
painting and hittesting code interprete the coordinates in the same
way as HTML code does.

Optimized SVGRootInlineBox::layoutChildBoxes() to reduce the complexity
from O(2^logN) to O(N) (where N = number of line box nodes).
SVGInlineFlowBox::calcuateBoundaries() will be removed in a later CL.

Fix bug that the indirect descendants of the root box were not
adjusted to the block coordinates.

BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb
Cr-Commit-Position: refs/heads/master@{#434270}

[Xianzhu, 2016-11-23 18:13:25]

Description was changed from

==========
Fix SVG vertical text layout issues

We layout SVG text fragments in physical coordinates of SVG <text>.
SVG text layout objects inherite from HTML text layout objects.
Previously we saved the physical coordinates in the HTML layout
objects as logical coordinates, and tried to override the HTML code
with SVG specific code to interprete the logical coordinates as
physical coordinates in painting and hittesting, etc. However, there
are still HTML code use the coordinates as logical and break some
cases.

Now convert the physical coordinates into appropriate coordinates
required by the HTML layout objects before saving them. Also let SVG
painting and hittesting code interprete the coordinates in the same
way as HTML code does.

Optimized SVGRootInlineBox::layoutChildBoxes() to reduce the complexity
from O(2^logN) to O(N) (where N = number of line box nodes).
SVGInlineFlowBox::calcuateBoundaries() will be removed in a later CL.

Fix bug that the indirect descendants of the root box were not
adjusted to the block coordinates.

BUG=666416
==========

to

==========
Fix SVG vertical text layout issues

We layout SVG text fragments in physical coordinates of SVG <text>.
SVG text layout objects inherite from HTML text layout objects.
Previously we saved the physical coordinates in the HTML layout
objects as logical coordinates, and tried to override the HTML code
with SVG specific code to interprete the logical coordinates as
physical coordinates in painting and hittesting, etc. However, there
are still HTML code use the coordinates as logical and break some
cases.

Now convert the physical coordinates into appropriate coordinates
required by the HTML layout objects before saving them. Also let SVG
painting and hittesting code interprete the coordinates in the same
way as HTML code does.

Optimized SVGRootInlineBox::layoutChildBoxes() to reduce the complexity
from O(2^logN) to O(N) (where N = number of line box nodes).
SVGInlineFlowBox::calcuateBoundaries() will be removed in a later CL.

Fix bug that the indirect descendants of the root box were not
adjusted to the block coordinates.

BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-11-23 18:13:31]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2016-11-23 18:13:48]

wangxianzhu@chromium.org changed reviewers:
+ fs@opera.com, pdr@chromium.org

[commit-bot: I haz the power, 2016-11-23 18:13:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-23 18:41:15]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 18:42:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-11-23 19:16:46]

lgtm

https://codereview.chromium.org/2524113002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp
(right):

https://codereview.chromium.org/2524113002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp:72:
LayoutRect childRect = layoutChildBoxes(*this);
Maybe consider sinking this into layoutRootBox even? (So we get the same
...layoutChildBoxes(...); setFrameRect(...) sequence as in the other flow box
case.)

[pdr., 2016-11-23 19:23:17]

On 2016/11/23 at 19:16:46, fs wrote:
> lgtm
> 
>
https://codereview.chromium.org/2524113002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp
(right):
> 
>
https://codereview.chromium.org/2524113002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp:72:
LayoutRect childRect = layoutChildBoxes(*this);
> Maybe consider sinking this into layoutRootBox even? (So we get the same
...layoutChildBoxes(...); setFrameRect(...) sequence as in the other flow box
case.)

LGTM 2

[Xianzhu, 2016-11-23 19:48:44]

https://codereview.chromium.org/2524113002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp
(right):

https://codereview.chromium.org/2524113002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp:72:
LayoutRect childRect = layoutChildBoxes(*this);
On 2016/11/23 19:16:46, fs wrote:
> Maybe consider sinking this into layoutRootBox even? (So we get the same
> ...layoutChildBoxes(...); setFrameRect(...) sequence as in the other flow box
> case.)

Modified layoutChildBoxes() to layoutInlineBoxes() which also layout the root
box. Moved remaining part of layoutRootBox() into layout().

[Xianzhu, 2016-11-23 19:48:52]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-23 19:48:52]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
fs@opera.com
Link to the patchset: https://codereview.chromium.org/2524113002/#ps40001
(title: "-")

[commit-bot: I haz the power, 2016-11-23 19:49:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-23 20:12:10]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-23 20:41:58]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-23 20:42:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 22:48:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479933718069920,
"parent_rev": "ca4857115ecc743eeee8f2ad02c5ae3c10ef060f", "commit_rev":
"e0c014c636288b3bcc22192983e0997a49cb2121"}

[commit-bot: I haz the power, 2016-11-23 22:48:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-23 22:51:30]

Description was changed from

==========
Fix SVG vertical text layout issues

We layout SVG text fragments in physical coordinates of SVG <text>.
SVG text layout objects inherite from HTML text layout objects.
Previously we saved the physical coordinates in the HTML layout
objects as logical coordinates, and tried to override the HTML code
with SVG specific code to interprete the logical coordinates as
physical coordinates in painting and hittesting, etc. However, there
are still HTML code use the coordinates as logical and break some
cases.

Now convert the physical coordinates into appropriate coordinates
required by the HTML layout objects before saving them. Also let SVG
painting and hittesting code interprete the coordinates in the same
way as HTML code does.

Optimized SVGRootInlineBox::layoutChildBoxes() to reduce the complexity
from O(2^logN) to O(N) (where N = number of line box nodes).
SVGInlineFlowBox::calcuateBoundaries() will be removed in a later CL.

Fix bug that the indirect descendants of the root box were not
adjusted to the block coordinates.

BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix SVG vertical text layout issues

We layout SVG text fragments in physical coordinates of SVG <text>.
SVG text layout objects inherite from HTML text layout objects.
Previously we saved the physical coordinates in the HTML layout
objects as logical coordinates, and tried to override the HTML code
with SVG specific code to interprete the logical coordinates as
physical coordinates in painting and hittesting, etc. However, there
are still HTML code use the coordinates as logical and break some
cases.

Now convert the physical coordinates into appropriate coordinates
required by the HTML layout objects before saving them. Also let SVG
painting and hittesting code interprete the coordinates in the same
way as HTML code does.

Optimized SVGRootInlineBox::layoutChildBoxes() to reduce the complexity
from O(2^logN) to O(N) (where N = number of line box nodes).
SVGInlineFlowBox::calcuateBoundaries() will be removed in a later CL.

Fix bug that the indirect descendants of the root box were not
adjusted to the block coordinates.

BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb
Cr-Commit-Position: refs/heads/master@{#434270}
==========

[commit-bot: I haz the power, 2016-11-23 22:51:31]

Patchset 3 (id:??) landed as
https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb
Cr-Commit-Position: refs/heads/master@{#434270}