third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp - Issue 2524113002: Fix SVG vertical text layout issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

Issue 2524113002: Fix SVG vertical text layout issues (Closed)

Patch Set: - Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/text/vertical-discrete-tspans-expected.html ('k') | third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp b/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

index 7c0eb62517af1c25c2ce38ccd07fd790c14a380a..a9d15577a710c694fd14ef482f689822391171de 100644

--- a/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

@@ -299,7 +299,7 @@ bool SVGInlineTextBox::nodeAtPoint(HitTestResult& result,

(hitRules.canHitFill &&

(getLineLayoutItem().style()->svgStyle().hasFill() ||

!hitRules.requireFill))) {

- LayoutRect rect(topLeft(), LayoutSize(logicalWidth(), logicalHeight()));

+ LayoutRect rect(locationIncludingFlipping(), size());

rect.moveBy(accumulatedOffset);

if (locationInContainer.intersects(rect)) {

LineLayoutSVGInlineText lineLayoutItem =