Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2523993003:
[test] Let presubmit only run over affected files. (Closed)
|
Created:
4 years ago by Michael Achenbach Modified:
4 years ago CC:
tandrii(chromium), v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Let presubmit only run over affected files.
Presubmit on upload and on trybot will use the affected files as
determined by the presubmit input_api.
The continuously run presubmit will use the old method and search all
files.
BUG=v8:5603
NOTRY=true
Committed: https://crrev.com/fa37f96e358a75e62ecbe105f0b676572b53c7c2
Cr-Commit-Position: refs/heads/master@{#41248}
Patch Set 1 #Patch Set 2 : .. #Patch Set 3 : .. #
Total comments: 1
Messages
Total messages: 22 (9 generated)
machenbach@chromium.org changed reviewers: + cbruni@chromium.org, jkummerow@chromium.org, jochen@chromium.org
PTAL
Description was changed from ========== [test] Let presubmit only run over affected files. BUG= ========== to ========== [test] Let presubmit only run over affected files. Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. ==========
tandrii@chromium.org changed reviewers: + tandrii@chromium.org
LGTM % wow 4-line long condition is impressive but takes long time to think about.
lgtm
On 2016/11/23 15:59:16, tandrii(chromium) wrote: > LGTM % wow 4-line long condition is impressive but takes long time to think > about. Well, it's supposed to be a strict subset of the old function. And there were a bunch of conditions in there...
Description was changed from ========== [test] Let presubmit only run over affected files. Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. ========== to ========== [test] Let presubmit only run over affected files. Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. BUG=v8:5603 ==========
https://codereview.chromium.org/2523993003/diff/40001/tools/presubmit.py File tools/presubmit.py (right): https://codereview.chromium.org/2523993003/diff/40001/tools/presubmit.py#newc... tools/presubmit.py:464: def CheckStatusFiles(workspace): Will also change this one in a follow up CL. Probably just takes a few miliseconds, but for consistency...
lgtm
Description was changed from ========== [test] Let presubmit only run over affected files. Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. BUG=v8:5603 ========== to ========== [test] Let presubmit only run over affected files. Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. BUG=v8:5603 NOTRY=true ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
so good... lgtm!
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479974932997570,
"parent_rev": "e305cca978b7311b091cf15154a6b604cc4f4cd8", "commit_rev":
"e241b27fa1aec691e9d8dd81325ec1225c9b7752"}
Message was sent while issue was closed.
Description was changed from ========== [test] Let presubmit only run over affected files. Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. BUG=v8:5603 NOTRY=true ========== to ========== [test] Let presubmit only run over affected files. Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. BUG=v8:5603 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [test] Let presubmit only run over affected files. Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. BUG=v8:5603 NOTRY=true ========== to ========== [test] Let presubmit only run over affected files. Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. BUG=v8:5603 NOTRY=true Committed: https://crrev.com/fa37f96e358a75e62ecbe105f0b676572b53c7c2 Cr-Commit-Position: refs/heads/master@{#41248} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/fa37f96e358a75e62ecbe105f0b676572b53c7c2 Cr-Commit-Position: refs/heads/master@{#41248}
Message was sent while issue was closed.
On 2016/11/24 08:11:00, commit-bot: I haz the power wrote: > Patchset 3 (id:??) landed as > https://crrev.com/fa37f96e358a75e62ecbe105f0b676572b53c7c2 > Cr-Commit-Position: refs/heads/master@{#41248} Hehe. Presubmit fails if you want to remove files. ProcessFiles expects to find the "affected" file and doesn't.
Message was sent while issue was closed.
On 2016/11/25 11:48:58, Yang wrote: > On 2016/11/24 08:11:00, commit-bot: I haz the power wrote: > > Patchset 3 (id:??) landed as > > https://crrev.com/fa37f96e358a75e62ecbe105f0b676572b53c7c2 > > Cr-Commit-Position: refs/heads/master@{#41248} > > Hehe. Presubmit fails if you want to remove files. ProcessFiles expects to find > the "affected" file and doesn't. Fix: https://codereview.chromium.org/2533583002
Message was sent while issue was closed.
On 2016/11/25 11:48:58, Yang wrote: > On 2016/11/24 08:11:00, commit-bot: I haz the power wrote: > > Patchset 3 (id:??) landed as > > https://crrev.com/fa37f96e358a75e62ecbe105f0b676572b53c7c2 > > Cr-Commit-Position: refs/heads/master@{#41248} > > Hehe. Presubmit fails if you want to remove files. ProcessFiles expects to find > the "affected" file and doesn't. Damn. The affected files method actually has a parameter for "include deleted". I thought it was false by default, but maybe it's true... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
