Issue 2533583002: Presubmit should be able to handle files being deleted.

Issue 2533583002: Presubmit should be able to handle files being deleted. (Closed)

Created:
4 years ago by Yang

Modified:
4 years ago

Reviewers:
Michael Achenbach

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Presubmit should be able to handle files being deleted. TBR=machenbach@chromium.org Committed: https://crrev.com/552b48036395626d20929360071c23dcd8456332 Cr-Commit-Position: refs/heads/master@{#41286}

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/presubmit.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 9 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533583002/1

4 years ago (2016-11-25 11:53:22 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/552b48036395626d20929360071c23dcd8456332 Cr-Commit-Position: refs/heads/master@{#41286}

4 years ago (2016-11-25 12:20:03 UTC) #7

Michael Achenbach

lgtm as workaround, thanks The deleted files shouldn't be passed to the method in the ...

4 years ago (2016-11-28 08:15:38 UTC) #8

Michael Achenbach

4 years ago (2016-11-28 08:15:38 UTC) #9

Message was sent while issue was closed.

lgtm as workaround, thanks

The deleted files shouldn't be passed to the method in the first place. Will
work on the real fix.