Explicitly specify target color space to ImageDecoder at creation

This is towards removing the global variable that specifies the target
color profile for all image decode.

The core of this change is the change to ImageDecoder::ColorSpaceOption.
Prior to this change, the options for image decode were
  * Ignore color entirely
  * "Apply" that global profile, whatever it happens to be
There was one other mode, behind the EnableColorCorrectRendering flag,
which would
  * Tag the SkImages that came out of the ImageDecoder with the embedded
    color profile.

After this change, we still have the same 3 options, but they no longer
use global variables or command line flags. The ColorSpaceOption enum
has three states
  * Ignore color entirely
  * Transform the image into an explicitly specified (in the
    constructor) color space.
  * Tag the SkImages for that come out of the ImageDecoder.

Most of the change is just plumbing these variables though all of the
ImageDecoder related classes. The two other parts are as follows.

This patch makes it explicit when SkColorSpaces related to an image
are to be used with the SkImages (and SkImageInfos) for the image.
Previously, this distinction was less clear.

This patch also plumbs the ColorSpaceOption correctly from ImageSource
through to ImageDecoder. The path is
  ImageSource ->
  DeferredImageDecoder ->
  DeferredImageGenerator ->
  ImageFrameGenerator ->
  ImageDecoder
This just involves stashing the ColorSpaceOption and target color space
at the required stages along the way, to ensure that the final
ImageDecoder is created with the initially-specified arguments.

R=pdr,junov
TBR=peter
BUG=667420
Committed: https://crrev.com/c8f175a4cbe14604f5b0f32b421a2be344a269bf
Cr-Commit-Position: refs/heads/master@{#435478}

[ccameron, 2016-11-23 05:01:24]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 05:01:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-11-23 05:26:39]

Description was changed from

==========
Explicitly specify target color space to ImageDecoder at creation



BUG=
==========

to

==========
This is towards removing the global variable that specifies the target
color profile for all image decode.

The core of this change is the change to ImageDecoder::ColorSpaceOption.
Prior to this change, the options for image decode were
  * Ignore color entirely
  * "Apply" that global profile, whatever it happens to be
There was one other mode, behind the EnableColorCorrectRendering flag,
which would
  * Tag the SkImages that came out of the ImageDecoder with the embedded
    color profile.

After this change, we still have the same 3 options, but they no longer
use global variables or command line flags. The ColorSpaceOption enum
has three states
  * Ignore color entirely
  * Transform the image into an explicitly specified (in the
    constructor) color space.
  * Tag the SkImages for that come out of the ImageDecoder.

Most of the change is just plumbing these variables though all of the
ImageDecoder related classes. The two other parts are as follows.

This patch makes it explicit when SkColorSpaces related to an image
are to be used with the SkImages (and SkImageInfos) for the image.
Previously, this distinction was less clear.

This patch also plumbs the ColorSpaceOption correctly from ImageSource
through to ImageDecoder. The path is
  ImageSource ->
  DeferredImageDecoder ->
  DeferredImageGenerator ->
  ImageFrameGenerator ->
  ImageDecoder
This just involves stashing the ColorSpaceOption and target color space
at the required stages along the way, to ensure that the final
ImageDecoder is created with the initially-specified arguments.

BUG=667420
==========

[ccameron, 2016-11-23 06:30:01]

This is the second part of
https://codereview.chromium.org/2512683003/

It's a bit long because it touches all of the places where we create an
ImageDecoder or one of its subclasses.

With this, we no longer have any "surprise" places that we're picking up the
global state. There are a dozen calls to the global, most of which are tests,
some of a clear replacement, and then a handful that will require some care.

https://codereview.chromium.org/2523943002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right):

https://codereview.chromium.org/2523943002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:103:
ColorSpaceTagged,
This (and below) is the core of the change -- renaming "Applied" to
"Transformed", and adding "Tagged".

https://codereview.chromium.org/2523943002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:122:
sk_sp<SkColorSpace> targetColorSpace) {
Adding this argument to create and the constructor accounts for most of the
diffs.

[ccameron, 2016-11-23 06:30:27]

ccameron@chromium.org changed reviewers:
+ esprehn@chromium.org

[ccameron, 2016-11-23 06:30:28]

Oops, I forgot to set Reviewers...

[ccameron, 2016-11-23 06:34:21]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 06:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-11-23 07:10:34]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 07:10:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 09:22:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 09:22:01]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-11-24 00:30:11]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 00:31:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 02:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:33:01]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[ccameron, 2016-11-28 19:40:41]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 19:41:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-11-28 20:10:09]

postprandial ping

[commit-bot: I haz the power, 2016-11-28 21:55:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:55:39]

Dry run: This issue passed the CQ dry run.

[msarett1, 2016-11-29 15:25:18]

msarett@chromium.org changed reviewers:
+ msarett@chromium.org

[ccameron, 2016-11-29 17:36:45]

post-postprandial ping

[ccameron, 2016-11-29 17:36:47]

post-postprandial ping

[ccameron, 2016-11-29 20:17:22]

ccameron@chromium.org changed reviewers:
+ junov@chromium.org
- esprehn@chromium.org

[ccameron, 2016-11-29 20:17:23]

Switching reviewer to junov@

Adding pdr@ for OWNER of third_party/WebKit/Source/web

[ccameron, 2016-11-30 18:39:48]

ping again

[Justin Novosad, 2016-11-30 19:28:17]

lgtm for Source/platform and Source/core

[pdr., 2016-11-30 19:46:32]

On 2016/11/30 at 19:28:17, junov wrote:
> lgtm for Source/platform and Source/core

LGTM for third_party/WebKit/Source/web

[ccameron, 2016-11-30 21:42:32]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-11-30 21:43:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 21:51:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 21:52:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ccameron, 2016-11-30 23:32:55]

Description was changed from

==========
This is towards removing the global variable that specifies the target
color profile for all image decode.

The core of this change is the change to ImageDecoder::ColorSpaceOption.
Prior to this change, the options for image decode were
  * Ignore color entirely
  * "Apply" that global profile, whatever it happens to be
There was one other mode, behind the EnableColorCorrectRendering flag,
which would
  * Tag the SkImages that came out of the ImageDecoder with the embedded
    color profile.

After this change, we still have the same 3 options, but they no longer
use global variables or command line flags. The ColorSpaceOption enum
has three states
  * Ignore color entirely
  * Transform the image into an explicitly specified (in the
    constructor) color space.
  * Tag the SkImages for that come out of the ImageDecoder.

Most of the change is just plumbing these variables though all of the
ImageDecoder related classes. The two other parts are as follows.

This patch makes it explicit when SkColorSpaces related to an image
are to be used with the SkImages (and SkImageInfos) for the image.
Previously, this distinction was less clear.

This patch also plumbs the ColorSpaceOption correctly from ImageSource
through to ImageDecoder. The path is
  ImageSource ->
  DeferredImageDecoder ->
  DeferredImageGenerator ->
  ImageFrameGenerator ->
  ImageDecoder
This just involves stashing the ColorSpaceOption and target color space
at the required stages along the way, to ensure that the final
ImageDecoder is created with the initially-specified arguments.

BUG=667420
==========

to

==========
This is towards removing the global variable that specifies the target
color profile for all image decode.

The core of this change is the change to ImageDecoder::ColorSpaceOption.
Prior to this change, the options for image decode were
  * Ignore color entirely
  * "Apply" that global profile, whatever it happens to be
There was one other mode, behind the EnableColorCorrectRendering flag,
which would
  * Tag the SkImages that came out of the ImageDecoder with the embedded
    color profile.

After this change, we still have the same 3 options, but they no longer
use global variables or command line flags. The ColorSpaceOption enum
has three states
  * Ignore color entirely
  * Transform the image into an explicitly specified (in the
    constructor) color space.
  * Tag the SkImages for that come out of the ImageDecoder.

Most of the change is just plumbing these variables though all of the
ImageDecoder related classes. The two other parts are as follows.

This patch makes it explicit when SkColorSpaces related to an image
are to be used with the SkImages (and SkImageInfos) for the image.
Previously, this distinction was less clear.

This patch also plumbs the ColorSpaceOption correctly from ImageSource
through to ImageDecoder. The path is
  ImageSource ->
  DeferredImageDecoder ->
  DeferredImageGenerator ->
  ImageFrameGenerator ->
  ImageDecoder
This just involves stashing the ColorSpaceOption and target color space
at the required stages along the way, to ensure that the final
ImageDecoder is created with the initially-specified arguments.

R=pdr,junov
TBR=peter
BUG=667420
==========

[ccameron, 2016-11-30 23:33:20]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-11-30 23:33:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 23:38:40]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480548800291040,
"parent_rev": "c993dccf1db82173280db7f3964b6772e39b4b97", "commit_rev":
"dae15af742118dfe06aa4fe718dab87a97ebe419"}

[commit-bot: I haz the power, 2016-11-30 23:39:06]

Description was changed from

==========
This is towards removing the global variable that specifies the target
color profile for all image decode.

The core of this change is the change to ImageDecoder::ColorSpaceOption.
Prior to this change, the options for image decode were
  * Ignore color entirely
  * "Apply" that global profile, whatever it happens to be
There was one other mode, behind the EnableColorCorrectRendering flag,
which would
  * Tag the SkImages that came out of the ImageDecoder with the embedded
    color profile.

After this change, we still have the same 3 options, but they no longer
use global variables or command line flags. The ColorSpaceOption enum
has three states
  * Ignore color entirely
  * Transform the image into an explicitly specified (in the
    constructor) color space.
  * Tag the SkImages for that come out of the ImageDecoder.

Most of the change is just plumbing these variables though all of the
ImageDecoder related classes. The two other parts are as follows.

This patch makes it explicit when SkColorSpaces related to an image
are to be used with the SkImages (and SkImageInfos) for the image.
Previously, this distinction was less clear.

This patch also plumbs the ColorSpaceOption correctly from ImageSource
through to ImageDecoder. The path is
  ImageSource ->
  DeferredImageDecoder ->
  DeferredImageGenerator ->
  ImageFrameGenerator ->
  ImageDecoder
This just involves stashing the ColorSpaceOption and target color space
at the required stages along the way, to ensure that the final
ImageDecoder is created with the initially-specified arguments.

R=pdr,junov
TBR=peter
BUG=667420
==========

to

==========
This is towards removing the global variable that specifies the target
color profile for all image decode.

The core of this change is the change to ImageDecoder::ColorSpaceOption.
Prior to this change, the options for image decode were
  * Ignore color entirely
  * "Apply" that global profile, whatever it happens to be
There was one other mode, behind the EnableColorCorrectRendering flag,
which would
  * Tag the SkImages that came out of the ImageDecoder with the embedded
    color profile.

After this change, we still have the same 3 options, but they no longer
use global variables or command line flags. The ColorSpaceOption enum
has three states
  * Ignore color entirely
  * Transform the image into an explicitly specified (in the
    constructor) color space.
  * Tag the SkImages for that come out of the ImageDecoder.

Most of the change is just plumbing these variables though all of the
ImageDecoder related classes. The two other parts are as follows.

This patch makes it explicit when SkColorSpaces related to an image
are to be used with the SkImages (and SkImageInfos) for the image.
Previously, this distinction was less clear.

This patch also plumbs the ColorSpaceOption correctly from ImageSource
through to ImageDecoder. The path is
  ImageSource ->
  DeferredImageDecoder ->
  DeferredImageGenerator ->
  ImageFrameGenerator ->
  ImageDecoder
This just involves stashing the ColorSpaceOption and target color space
at the required stages along the way, to ensure that the final
ImageDecoder is created with the initially-specified arguments.

R=pdr,junov
TBR=peter
BUG=667420
==========

[commit-bot: I haz the power, 2016-11-30 23:39:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-30 23:42:12]

Description was changed from

==========
This is towards removing the global variable that specifies the target
color profile for all image decode.

The core of this change is the change to ImageDecoder::ColorSpaceOption.
Prior to this change, the options for image decode were
  * Ignore color entirely
  * "Apply" that global profile, whatever it happens to be
There was one other mode, behind the EnableColorCorrectRendering flag,
which would
  * Tag the SkImages that came out of the ImageDecoder with the embedded
    color profile.

After this change, we still have the same 3 options, but they no longer
use global variables or command line flags. The ColorSpaceOption enum
has three states
  * Ignore color entirely
  * Transform the image into an explicitly specified (in the
    constructor) color space.
  * Tag the SkImages for that come out of the ImageDecoder.

Most of the change is just plumbing these variables though all of the
ImageDecoder related classes. The two other parts are as follows.

This patch makes it explicit when SkColorSpaces related to an image
are to be used with the SkImages (and SkImageInfos) for the image.
Previously, this distinction was less clear.

This patch also plumbs the ColorSpaceOption correctly from ImageSource
through to ImageDecoder. The path is
  ImageSource ->
  DeferredImageDecoder ->
  DeferredImageGenerator ->
  ImageFrameGenerator ->
  ImageDecoder
This just involves stashing the ColorSpaceOption and target color space
at the required stages along the way, to ensure that the final
ImageDecoder is created with the initially-specified arguments.

R=pdr,junov
TBR=peter
BUG=667420
==========

to

==========
This is towards removing the global variable that specifies the target
color profile for all image decode.

The core of this change is the change to ImageDecoder::ColorSpaceOption.
Prior to this change, the options for image decode were
  * Ignore color entirely
  * "Apply" that global profile, whatever it happens to be
There was one other mode, behind the EnableColorCorrectRendering flag,
which would
  * Tag the SkImages that came out of the ImageDecoder with the embedded
    color profile.

After this change, we still have the same 3 options, but they no longer
use global variables or command line flags. The ColorSpaceOption enum
has three states
  * Ignore color entirely
  * Transform the image into an explicitly specified (in the
    constructor) color space.
  * Tag the SkImages for that come out of the ImageDecoder.

Most of the change is just plumbing these variables though all of the
ImageDecoder related classes. The two other parts are as follows.

This patch makes it explicit when SkColorSpaces related to an image
are to be used with the SkImages (and SkImageInfos) for the image.
Previously, this distinction was less clear.

This patch also plumbs the ColorSpaceOption correctly from ImageSource
through to ImageDecoder. The path is
  ImageSource ->
  DeferredImageDecoder ->
  DeferredImageGenerator ->
  ImageFrameGenerator ->
  ImageDecoder
This just involves stashing the ColorSpaceOption and target color space
at the required stages along the way, to ensure that the final
ImageDecoder is created with the initially-specified arguments.

R=pdr,junov
TBR=peter
BUG=667420

Committed: https://crrev.com/c8f175a4cbe14604f5b0f32b421a2be344a269bf
Cr-Commit-Position: refs/heads/master@{#435478}
==========

[commit-bot: I haz the power, 2016-11-30 23:42:13]

Patchset 5 (id:??) landed as
https://crrev.com/c8f175a4cbe14604f5b0f32b421a2be344a269bf
Cr-Commit-Position: refs/heads/master@{#435478}