Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h

Issue 2523943002: Explicitly specify target color space to ImageDecoder at creation (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 #define BMPImageDecoder_h 32 #define BMPImageDecoder_h
33 33
34 #include "platform/image-decoders/bmp/BMPImageReader.h" 34 #include "platform/image-decoders/bmp/BMPImageReader.h"
35 #include <memory> 35 #include <memory>
36 36
37 namespace blink { 37 namespace blink {
38 38
39 // This class decodes the BMP image format. 39 // This class decodes the BMP image format.
40 class PLATFORM_EXPORT BMPImageDecoder final : public ImageDecoder { 40 class PLATFORM_EXPORT BMPImageDecoder final : public ImageDecoder {
41 public: 41 public:
42 BMPImageDecoder(AlphaOption, ColorSpaceOption, size_t maxDecodedBytes); 42 BMPImageDecoder(AlphaOption,
43 ColorSpaceOption,
44 sk_sp<SkColorSpace>,
45 size_t maxDecodedBytes);
43 46
44 // ImageDecoder: 47 // ImageDecoder:
45 String filenameExtension() const override { return "bmp"; } 48 String filenameExtension() const override { return "bmp"; }
46 void onSetData(SegmentReader*) override; 49 void onSetData(SegmentReader*) override;
47 // CAUTION: setFailed() deletes |m_reader|. Be careful to avoid 50 // CAUTION: setFailed() deletes |m_reader|. Be careful to avoid
48 // accessing deleted memory, especially when calling this from inside 51 // accessing deleted memory, especially when calling this from inside
49 // BMPImageReader! 52 // BMPImageReader!
50 bool setFailed() override; 53 bool setFailed() override;
51 54
52 private: 55 private:
(...skipping 20 matching lines...) Expand all
73 // BMPImageReader takes over this will not be updated further. 76 // BMPImageReader takes over this will not be updated further.
74 size_t m_decodedOffset; 77 size_t m_decodedOffset;
75 78
76 // The reader used to do most of the BMP decoding. 79 // The reader used to do most of the BMP decoding.
77 std::unique_ptr<BMPImageReader> m_reader; 80 std::unique_ptr<BMPImageReader> m_reader;
78 }; 81 };
79 82
80 } // namespace blink 83 } // namespace blink
81 84
82 #endif 85 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698