Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2523903002: Document::updateHoverActiveState only cancel hover and active state when hitting native scrollbar (Closed)
Patch Set: comment update Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 190c5c7e242c96804b85905e39ea7b9278c24185..2ae3345991feceaf3c4cdc7dad5bad156c5b1c07 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -10491,6 +10491,7 @@ TEST_F(WebFrameTest, MouseOverLinkAndOverlayScrollbar) {
EXPECT_TRUE(hitTestResult.URLElement());
EXPECT_TRUE(hitTestResult.innerElement());
EXPECT_TRUE(hitTestResult.scrollbar());
+ EXPECT_FALSE(hitTestResult.scrollbar()->isCustomScrollbar());
// Mouse over link. Mouse cursor should be hand.
PlatformMouseEvent mouseMoveOverLinkEvent(
@@ -10558,6 +10559,60 @@ TEST_F(WebFrameTest, MouseOverLinkAndOverlayScrollbar) {
document->frame()->eventHandler().handleMouseReleaseEvent(MouseReleaseEvent);
}
+
+// Makes sure that mouse hover over an custom scrollbar doesn't change the
+// activate elements.
+TEST_F(WebFrameTest, MouseOverCustomScrollbar) {
+ registerMockedHttpURLLoad("custom-scrollbar-hover.html");
+ FrameTestHelpers::WebViewHelper webViewHelper;
+ WebViewImpl* webView = webViewHelper.initializeAndLoad(
+ m_baseURL + "custom-scrollbar-hover.html");
+
+ webViewHelper.resize(WebSize(200, 200));
+
+ webView->updateAllLifecyclePhases();
+
+ Document* document = toLocalFrame(webView->page()->mainFrame())->document();
+
+ Element* scrollbarDiv = document->getElementById("scrollbar");
+ EXPECT_TRUE(scrollbarDiv);
+
+ // Ensure hittest only has DIV
+ HitTestResult hitTestResult = webView->coreHitTestResultAt(WebPoint(1, 1));
+
+ EXPECT_TRUE(hitTestResult.innerElement());
+ EXPECT_FALSE(hitTestResult.scrollbar());
+
+ // Mouse over DIV
+ PlatformMouseEvent mouseMoveOverDiv(
+ IntPoint(1, 1), IntPoint(1, 1), WebPointerProperties::Button::NoButton,
+ PlatformEvent::MouseMoved, 0, PlatformEvent::NoModifiers,
+ WTF::monotonicallyIncreasingTime());
+ document->frame()->eventHandler().handleMouseMoveEvent(mouseMoveOverDiv);
+
+ // DIV :hover
+ EXPECT_EQ(document->hoverNode(), scrollbarDiv);
+
+ // Ensure hittest has DIV and scrollbar
+ hitTestResult = webView->coreHitTestResultAt(WebPoint(175, 1));
+
+ EXPECT_TRUE(hitTestResult.innerElement());
+ EXPECT_TRUE(hitTestResult.scrollbar());
+ EXPECT_TRUE(hitTestResult.scrollbar()->isCustomScrollbar());
+
+ // Mouse over scrollbar
+ PlatformMouseEvent mouseMoveOverDivAndScrollbar(
+ IntPoint(175, 1), IntPoint(175, 1),
+ WebPointerProperties::Button::NoButton, PlatformEvent::MouseMoved, 0,
+ PlatformEvent::NoModifiers, WTF::monotonicallyIncreasingTime());
+ document->frame()->eventHandler().handleMouseMoveEvent(
+ mouseMoveOverDivAndScrollbar);
+
+ // Custom not change the DIV :hover
+ EXPECT_EQ(document->hoverNode(), scrollbarDiv);
+ EXPECT_EQ(hitTestResult.scrollbar()->hoveredPart(), ScrollbarPart::ThumbPart);
+}
+
static void disableCompositing(WebSettings* settings) {
settings->setAcceleratedCompositingEnabled(false);
settings->setPreferCompositingToLCDTextEnabled(false);

Powered by Google App Engine
This is Rietveld 408576698