Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2523903002: Document::updateHoverActiveState only cancel hover and active state when hitting native scrollbar (Closed)
Patch Set: comment update Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index 5310a5bd9647c2fa2c37b82be06fa5f3442b2cd0..5f190e34632e3af7be1801d3fd9989d948fbce0d 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -812,7 +812,7 @@ WebInputEventResult EventHandler::handleMouseMoveOrLeaveEvent(
// So we must force the hit-test to fail, while still clearing hover/active
// state.
if (forceLeave) {
- m_frame->document()->updateHoverActiveState(request, nullptr, false);
+ m_frame->document()->updateHoverActiveState(request, nullptr, nullptr);
} else {
mev = EventHandlingUtil::performMouseEventHitTest(m_frame, request,
mouseEvent);
@@ -1526,13 +1526,13 @@ void EventHandler::updateGestureHoverActiveState(const HitTestRequest& request,
// If the old hovered frame is different from the new hovered frame.
// we should clear the old hovered node from the old hovered frame.
if (newHoverFrame != oldHoverFrame)
- doc->updateHoverActiveState(request, nullptr, false);
+ doc->updateHoverActiveState(request, nullptr, nullptr);
}
}
// Recursively set the new active/hover states on every frame in the chain of
// innerElement.
- m_frame->document()->updateHoverActiveState(request, innerElement, false);
+ m_frame->document()->updateHoverActiveState(request, innerElement, nullptr);
}
// Update the mouseover/mouseenter/mouseout/mouseleave events across all frames
@@ -1941,7 +1941,7 @@ void EventHandler::activeIntervalTimerFired(TimerBase*) {
HitTestRequest request(HitTestRequest::TouchEvent |
HitTestRequest::Release);
m_frame->document()->updateHoverActiveState(
- request, m_lastDeferredTapElement.get(), false);
+ request, m_lastDeferredTapElement.get(), nullptr);
}
m_lastDeferredTapElement = nullptr;
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698