Remove DisplayChangeObserver ash dependencies.

Remove DisplayChangeObserver ash dependencies.

Before moving DisplayChangeObserver from src/ash/display to
src/ui/display we need to remove all ash dependencies.

1. DisplayManager and DisplayConfigurator are injected instead of
   getting them from ash::Shell.
2. DCO no longer acts as a ShellObserver for shutdown. Add
   ShutdownObserver to do this instead.
3. Move display strings from ash to ui.

BUG=667344
Committed: https://crrev.com/98748a534f51488863475326bcc87b510c90df1d
Cr-Commit-Position: refs/heads/master@{#436129}

[kylechar, 2016-11-23 16:22:06]

Description was changed from

==========
Remove DisplayChangeObserver ash dependencies.

Before moving DisplayChangeObserver from src/ash/display to
src/ui/display we need to remove all ash dependencies.

1. DCO has DisplayManager and DisplayConfigurator injected instead of
   getting from ash::Shell.
2. DCO no longer handles shutdown. ash::ShutdownObserver.

BUG=
==========

to

==========
Remove DisplayChangeObserver ash dependencies.

Before moving DisplayChangeObserver from src/ash/display to
src/ui/display we need to remove all ash dependencies.

1. DisplayManager and DisplayConfigurator are injected instead of
   getting them from ash::Shell.
2. DCO no longer acts as a ShellObserver for shutdown. Add
   ShutdownObserver to do this instead.
3. DCO gets strings from DisplayStringProvider. DisplayManager has a
   similar requirement. Remove the string methods from DM::Observer
   interface and add a new interface used by both DM and DCO.
   AshDisplayStringProvider is injected into both.

BUG=667344
==========

[kylechar, 2016-11-23 19:57:57]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 19:58:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 22:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 22:59:16]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-11-24 19:38:52]

kylechar@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2016-11-30 18:17:10]

https://codereview.chromium.org/2523873002/diff/20001/ash/display/display_cha...
File ash/display/display_change_observer_chromeos.cc (left):

https://codereview.chromium.org/2523873002/diff/20001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.cc:52: };
This is defined for readability/explanation purpose, so let's keep it.

https://codereview.chromium.org/2523873002/diff/20001/ui/display/manager/disp...
File ui/display/manager/display_string_provider.h (right):

https://codereview.chromium.org/2523873002/diff/20001/ui/display/manager/disp...
ui/display/manager/display_string_provider.h:19: virtual std::string
GetUnknownDisplayNameString() = 0;
Using a interface looks overkill. Can't you just inject string and update when
locale changed? Or you can just define in ui/.

[kylechar, 2016-11-30 21:46:02]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[kylechar, 2016-11-30 21:46:03]

+sadrul for the general ui/* stuff.

https://codereview.chromium.org/2523873002/diff/20001/ash/display/display_cha...
File ash/display/display_change_observer_chromeos.cc (left):

https://codereview.chromium.org/2523873002/diff/20001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.cc:52: };
On 2016/11/30 18:17:09, oshima wrote:
> This is defined for readability/explanation purpose, so let's keep it.

Done.

https://codereview.chromium.org/2523873002/diff/20001/ui/display/manager/disp...
File ui/display/manager/display_string_provider.h (right):

https://codereview.chromium.org/2523873002/diff/20001/ui/display/manager/disp...
ui/display/manager/display_string_provider.h:19: virtual std::string
GetUnknownDisplayNameString() = 0;
On 2016/11/30 18:17:09, oshima wrote:
> Using a interface looks overkill. Can't you just inject string and update when
> locale changed? Or you can just define in ui/. 

I discussed this with sadrul briefly. We will need the strings in ui/ eventually
so I'll go with that solution. I will need to split the //ui/display target into
two though because //ui/base depends on //ui/display now, so we can't use
localization utilities in //ui/display.

Finishing up that split now as a separate CL since it will be rather large.

[kylechar, 2016-12-01 15:28:57]

Description was changed from

==========
Remove DisplayChangeObserver ash dependencies.

Before moving DisplayChangeObserver from src/ash/display to
src/ui/display we need to remove all ash dependencies.

1. DisplayManager and DisplayConfigurator are injected instead of
   getting them from ash::Shell.
2. DCO no longer acts as a ShellObserver for shutdown. Add
   ShutdownObserver to do this instead.
3. DCO gets strings from DisplayStringProvider. DisplayManager has a
   similar requirement. Remove the string methods from DM::Observer
   interface and add a new interface used by both DM and DCO.
   AshDisplayStringProvider is injected into both.

BUG=667344
==========

to

==========
Remove DisplayChangeObserver ash dependencies.

Before moving DisplayChangeObserver from src/ash/display to
src/ui/display we need to remove all ash dependencies.

1. DisplayManager and DisplayConfigurator are injected instead of
   getting them from ash::Shell.
2. DCO no longer acts as a ShellObserver for shutdown. Add
   ShutdownObserver to do this instead.
3. Move display strings from ash to ui.

BUG=667344
==========

[sadrul, 2016-12-02 00:55:49]

lgtm

[kylechar, 2016-12-02 14:36:53]

This is rebased on the new build target and the DisplayStringProvider interface
is gone.

[kylechar, 2016-12-02 14:38:46]

Patchset #4 (id:60001) has been deleted

[kylechar, 2016-12-02 16:27:41]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 16:27:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 17:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 17:19:49]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-12-02 19:07:46]

lgtm

https://codereview.chromium.org/2523873002/diff/80001/ash/display/display_cha...
File ash/display/display_change_observer_chromeos.h (right):

https://codereview.chromium.org/2523873002/diff/80001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.h:73: private:
can you document ownership/lifetime of these objects?

[kylechar, 2016-12-02 19:40:16]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 19:41:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2016-12-02 20:32:36]

Thanks oshima/sadrul!

https://codereview.chromium.org/2523873002/diff/80001/ash/display/display_cha...
File ash/display/display_change_observer_chromeos.h (right):

https://codereview.chromium.org/2523873002/diff/80001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.h:73: private:
On 2016/12/02 19:07:45, oshima wrote:
> can you document ownership/lifetime of these objects?

Done.

[commit-bot: I haz the power, 2016-12-02 20:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 20:42:55]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-12-03 01:22:59]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-12-03 01:23:00]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2523873002/#ps100001
(title: "Change DCO constructor slightly.")

[commit-bot: I haz the power, 2016-12-03 01:23:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 01:33:26]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480728179607440,
"parent_rev": "b356593b64b632c2b684da2c9c31c1f6f93364ba", "commit_rev":
"ddc850aa492c921d36744a25e15965eea5e05165"}

[commit-bot: I haz the power, 2016-12-03 01:33:55]

Description was changed from

==========
Remove DisplayChangeObserver ash dependencies.

Before moving DisplayChangeObserver from src/ash/display to
src/ui/display we need to remove all ash dependencies.

1. DisplayManager and DisplayConfigurator are injected instead of
   getting them from ash::Shell.
2. DCO no longer acts as a ShellObserver for shutdown. Add
   ShutdownObserver to do this instead.
3. Move display strings from ash to ui.

BUG=667344
==========

to

==========
Remove DisplayChangeObserver ash dependencies.

Before moving DisplayChangeObserver from src/ash/display to
src/ui/display we need to remove all ash dependencies.

1. DisplayManager and DisplayConfigurator are injected instead of
   getting them from ash::Shell.
2. DCO no longer acts as a ShellObserver for shutdown. Add
   ShutdownObserver to do this instead.
3. Move display strings from ash to ui.

BUG=667344
==========

[commit-bot: I haz the power, 2016-12-03 01:33:58]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-12-03 01:36:39]

Description was changed from

==========
Remove DisplayChangeObserver ash dependencies.

Before moving DisplayChangeObserver from src/ash/display to
src/ui/display we need to remove all ash dependencies.

1. DisplayManager and DisplayConfigurator are injected instead of
   getting them from ash::Shell.
2. DCO no longer acts as a ShellObserver for shutdown. Add
   ShutdownObserver to do this instead.
3. Move display strings from ash to ui.

BUG=667344
==========

to

==========
Remove DisplayChangeObserver ash dependencies.

Before moving DisplayChangeObserver from src/ash/display to
src/ui/display we need to remove all ash dependencies.

1. DisplayManager and DisplayConfigurator are injected instead of
   getting them from ash::Shell.
2. DCO no longer acts as a ShellObserver for shutdown. Add
   ShutdownObserver to do this instead.
3. Move display strings from ash to ui.

BUG=667344

Committed: https://crrev.com/98748a534f51488863475326bcc87b510c90df1d
Cr-Commit-Position: refs/heads/master@{#436129}
==========

[commit-bot: I haz the power, 2016-12-03 01:36:40]

Patchset 5 (id:??) landed as
https://crrev.com/98748a534f51488863475326bcc87b510c90df1d
Cr-Commit-Position: refs/heads/master@{#436129}