Move DisplayChangeObserver + tests from ash to ui.

Move DisplayChangeObserver + tests from ash to ui.

Move DCO + tests from ash to ui. All of the ash dependencies were
already removed, so it's mostly just changing the file location and
namespace.

BUG=667344
Committed: https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2
Cr-Commit-Position: refs/heads/master@{#436186}

[kylechar, 2016-11-23 20:43:55]

Description was changed from

==========
Move DisplayChangeObserver + tests from ash to ui.

Move DCO + tests from ash to ui. All of the ash dependencies were
already removed, so it's mostly just changing the file location and
namespace.

The only change is how UserActivityDetector gets called when the
displays state is about to change. //ui/display can't depend on
//ui/base to use UAD. This may have to work a bit differently with
mustash too. Replace UAD call with a callback. Ash adds the callback to
UAD when initializating DCO.

BUG=667344
==========

to

==========
Move DisplayChangeObserver + tests from ash to ui.

Move DCO + tests from ash to ui. All of the ash dependencies were
already removed, so it's mostly just changing the file location and
namespace.

The only change is how UserActivityDetector gets called when the
displays state is about to change. //ui/display can't depend on
//ui/base to use UAD. This may have to work a bit differently with
mustash too. Replace UAD call with a callback. Ash adds the callback to
UAD when initializating DCO.

BUG=667344
==========

[kylechar, 2016-11-28 15:41:39]

kylechar@chromium.org changed reviewers:
+ oshima@chromium.org, rjkroege@chromium.org, sadrul@chromium.org

[kylechar, 2016-11-28 15:41:40]

+oshima for ash/* and ui/display/*
+sadrul for ui/base/*
+rjkroege FYI

[kylechar, 2016-11-28 15:42:52]

Patchset #2 (id:20001) has been deleted

[sadrul, 2016-11-29 02:09:27]

https://codereview.chromium.org/2524863003/diff/40001/ui/display/chromeos/dis...
File ui/display/chromeos/display_change_observer.h (right):

https://codereview.chromium.org/2524863003/diff/40001/ui/display/chromeos/dis...
ui/display/chromeos/display_change_observer.h:28: class DISPLAY_EXPORT
DisplayChangeObserver
Hm. display::DisplayChangeObserver gets updates from
display::DisplayConfigurator, and notifies display::DisplayManager. Why does the
external code need to set it up explicitly? Can this be set up by either the
DisplayConfigurator and/or DisplayManager instead?

[kylechar, 2016-11-29 14:37:07]

https://codereview.chromium.org/2524863003/diff/40001/ui/display/chromeos/dis...
File ui/display/chromeos/display_change_observer.h (right):

https://codereview.chromium.org/2524863003/diff/40001/ui/display/chromeos/dis...
ui/display/chromeos/display_change_observer.h:28: class DISPLAY_EXPORT
DisplayChangeObserver
On 2016/11/29 02:09:27, sadrul wrote:
> Hm. display::DisplayChangeObserver gets updates from
> display::DisplayConfigurator, and notifies display::DisplayManager. Why does
the
> external code need to set it up explicitly? Can this be set up by either the
> DisplayConfigurator and/or DisplayManager instead?

I think it kind of just evolved this way. I tried to keep the structure as
similar as possible in this CL. Having DisplayConfigurator create
DisplayChangeObserver would work fine, except for //ui/display can't add the
UserActivityDetector callback (but the callback could be added to
DisplayConfigurator instead from ash or there could be a new
//ui/display/chromeos target added).

In general there is a lot of refactoring that could go into the
DisplayConfigurator --> DisplayChangeObserver --> DisplayManager system but I'm
not convinced it should happen in the same CL that moves DisplayChangeObserver.

[sadrul, 2016-11-29 18:24:40]

lgtm

https://codereview.chromium.org/2524863003/diff/40001/ui/base/user_activity/u...
File ui/base/user_activity/user_activity_detector.h (right):

https://codereview.chromium.org/2524863003/diff/40001/ui/base/user_activity/u...
ui/base/user_activity/user_activity_detector.h:37: static void
OnDisplayPowerChangingStatic();
Do we need 'Static'?

https://codereview.chromium.org/2524863003/diff/40001/ui/display/chromeos/dis...
File ui/display/chromeos/display_change_observer.h (right):

https://codereview.chromium.org/2524863003/diff/40001/ui/display/chromeos/dis...
ui/display/chromeos/display_change_observer.h:28: class DISPLAY_EXPORT
DisplayChangeObserver
On 2016/11/29 14:37:07, kylechar wrote:
> On 2016/11/29 02:09:27, sadrul wrote:
> > Hm. display::DisplayChangeObserver gets updates from
> > display::DisplayConfigurator, and notifies display::DisplayManager. Why does
> the
> > external code need to set it up explicitly? Can this be set up by either the
> > DisplayConfigurator and/or DisplayManager instead?
> 
> I think it kind of just evolved this way. I tried to keep the structure as
> similar as possible in this CL. Having DisplayConfigurator create
> DisplayChangeObserver would work fine, except for //ui/display can't add the
> UserActivityDetector callback (but the callback could be added to
> DisplayConfigurator instead from ash or there could be a new
> //ui/display/chromeos target added).
> 
> In general there is a lot of refactoring that could go into the
> DisplayConfigurator --> DisplayChangeObserver --> DisplayManager system but
I'm
> not convinced it should happen in the same CL that moves
DisplayChangeObserver.

Oh yeah, that shouldn't happen with the file-move. Maybe file a bug and
reference that from here so this is tracked? If there are other cleanups that
are possible, it'd be good to file separate bugs for those too.

[rjkroege, 2016-11-29 19:18:14]

lgtm

[kylechar, 2016-11-30 22:41:03]

Description was changed from

==========
Move DisplayChangeObserver + tests from ash to ui.

Move DCO + tests from ash to ui. All of the ash dependencies were
already removed, so it's mostly just changing the file location and
namespace.

The only change is how UserActivityDetector gets called when the
displays state is about to change. //ui/display can't depend on
//ui/base to use UAD. This may have to work a bit differently with
mustash too. Replace UAD call with a callback. Ash adds the callback to
UAD when initializating DCO.

BUG=667344
==========

to

==========
Move DisplayChangeObserver + tests from ash to ui.

Move DCO + tests from ash to ui. All of the ash dependencies were
already removed, so it's mostly just changing the file location and
namespace.

BUG=667344
==========

[kylechar, 2016-11-30 22:53:31]

https://codereview.chromium.org/2524863003/diff/40001/ui/base/user_activity/u...
File ui/base/user_activity/user_activity_detector.h (right):

https://codereview.chromium.org/2524863003/diff/40001/ui/base/user_activity/u...
ui/base/user_activity/user_activity_detector.h:37: static void
OnDisplayPowerChangingStatic();
On 2016/11/29 18:24:40, sadrul wrote:
> Do we need 'Static'?

A change in a parent CL has made this unnecessary regardless.

[kylechar, 2016-12-02 18:15:45]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 18:15:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-12-02 19:28:47]

lgtm (sorry forgot this one)

[commit-bot: I haz the power, 2016-12-02 19:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 19:36:53]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-12-03 01:33:45]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-12-03 01:33:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, sadrul@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2524863003/#ps100001
(title: "Rebase (again).")

[commit-bot: I haz the power, 2016-12-03 01:34:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 01:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 01:37:18]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kylechar, 2016-12-04 03:29:19]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-12-04 03:29:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, oshima@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2524863003/#ps120001
(title: "Rebase (again.. again.)")

[commit-bot: I haz the power, 2016-12-04 03:29:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-04 04:21:40]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1480822159095830,
"parent_rev": "3c1ef8bd0dfbb3f6741bd75a644cd7e5ed080926", "commit_rev":
"a0573c554666b6e7602b3d3d759b565dc98858f1"}

[commit-bot: I haz the power, 2016-12-04 04:22:42]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-12-04 04:25:42]

Description was changed from

==========
Move DisplayChangeObserver + tests from ash to ui.

Move DCO + tests from ash to ui. All of the ash dependencies were
already removed, so it's mostly just changing the file location and
namespace.

BUG=667344
==========

to

==========
Move DisplayChangeObserver + tests from ash to ui.

Move DCO + tests from ash to ui. All of the ash dependencies were
already removed, so it's mostly just changing the file location and
namespace.

BUG=667344

Committed: https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2
Cr-Commit-Position: refs/heads/master@{#436186}
==========

[commit-bot: I haz the power, 2016-12-04 04:25:43]

Patchset 6 (id:??) landed as
https://crrev.com/f2e4e41bfcf6b36c5e22d9798eb3aafed8e87ae2
Cr-Commit-Position: refs/heads/master@{#436186}