Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2523823003:
[DevTools] Do not collapse toolbars (Closed)
|
Created:
4 years ago by eostroukhov Modified:
3 years, 10 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Do not collapse toolbars
R=dgozman@chromium.org, pfeldman@chromium.org
BUG=640169
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2523823003
Cr-Commit-Position: refs/heads/master@{#452846}
Committed: https://chromium.googlesource.com/chromium/src/+/69b28c5c195c33922ac2185df859e722e109e156
Patch Set 1 #
Total comments: 1
Patch Set 2 : Added wrappable & resizable #Patch Set 3 : Right aligned the "show all" checkbox #
Total comments: 2
Patch Set 4 : [DevTools] Do not collapse toolbars #
Messages
Total messages: 34 (21 generated)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Please consider. I visually validated the fix...
https://codereview.chromium.org/2523823003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui/toolbar.css (left): https://codereview.chromium.org/2523823003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/toolbar.css:16: overflow: hidden; We actually need this to be truncated in other places. I believe you can use makeWrappable() instead.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== [DevTools] Do not collapse toolbars R=dgozman@chromium.org, pfeldman@chromium.org BUG=640169 ========== to ========== [DevTools] Do not collapse toolbars R=dgozman@chromium.org, pfeldman@chromium.org BUG=640169 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2523823003/diff/1/third_party/WebKit/Source/d... > third_party/WebKit/Source/devtools/front_end/ui/toolbar.css:16: overflow: > hidden; > We actually need this to be truncated in other places. > I believe you can use makeWrappable() instead. IMHO, the best result is if the toolbar is made wrappable and the height is unconstrained - then the checkboxes can go in multiple rows.
Thank you for the review. Please take another look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dgozman@chromium.org changed reviewers: + chowse@chromium.org
Let's ask Chris about growing toolbars - could you please take a look at the bug to see what we are talking about?
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Uploaded a new version. I've shown this to Chris and he suggested always showing the "show all" checkbox on the right, which I implemented. There's no need for a spacer element now. Previously, Show All would be left-aligned if it was the only element in the row.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
is this relevant?
On 2017/02/23 01:20:39, pfeldman wrote: > is this relevant? Yes.
https://codereview.chromium.org/2523823003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js (right): https://codereview.chromium.org/2523823003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js:16: this._toolbar.makeWrappable(); Let's make 'growVertically' a parameter of makeWrappable
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Please take another look. https://codereview.chromium.org/2523823003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js (right): https://codereview.chromium.org/2523823003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js:16: this._toolbar.makeWrappable(); On 2017/02/23 21:12:15, pfeldman wrote: > Let's make 'growVertically' a parameter of makeWrappable Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by eostroukhov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487953571745580,
"parent_rev": "271d08b32e78ccf8117c6fc9b6e146e5d5ab6ed2", "commit_rev":
"69b28c5c195c33922ac2185df859e722e109e156"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Do not collapse toolbars R=dgozman@chromium.org, pfeldman@chromium.org BUG=640169 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [DevTools] Do not collapse toolbars R=dgozman@chromium.org, pfeldman@chromium.org BUG=640169 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2523823003 Cr-Commit-Position: refs/heads/master@{#452846} Committed: https://chromium.googlesource.com/chromium/src/+/69b28c5c195c33922ac2185df859... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/69b28c5c195c33922ac2185df859... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
