Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2523803002: Silence the overly verbose skipped files warning when extracting CRX files (Closed)

Created:
4 years, 1 month ago by meacer
Modified:
4 years, 1 month ago
Reviewers:
Devlin, hshi1
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Silence the overly verbose skipped files warning when extracting CRX files CRX files are extracted twice: Once for only manifest.json, once for the rest of the contents. Extracting manifest.json causes a lot of noise in debug builds since all other files are skipped. Suppress the log statements when extracting manifest.json. BUG=645263 Committed: https://crrev.com/a98b44daed1683b35f0b5b638f5693aebf0dab5a Cr-Commit-Position: refs/heads/master@{#433984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M extensions/utility/utility_handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/zlib/google/zip.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/zlib/google/zip.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
meacer
Could you please take a look? Thanks.
4 years, 1 month ago (2016-11-22 18:50:22 UTC) #3
hshi1
lgtm
4 years, 1 month ago (2016-11-22 19:09:48 UTC) #4
Devlin
lgtm
4 years, 1 month ago (2016-11-22 19:42:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523803002/1
4 years, 1 month ago (2016-11-22 19:54:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 21:27:08 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 21:29:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a98b44daed1683b35f0b5b638f5693aebf0dab5a
Cr-Commit-Position: refs/heads/master@{#433984}

Powered by Google App Engine
This is Rietveld 408576698