Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/zlib/google/zip.cc

Issue 2523803002: Silence the overly verbose skipped files warning when extracting CRX files (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/zlib/google/zip.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/zlib/google/zip.cc
diff --git a/third_party/zlib/google/zip.cc b/third_party/zlib/google/zip.cc
index 31f0ace7af89f0fdb997ef8309e7d3fcc131ed8d..f0183d3f364034e03dd3abb822f3818604332cc5 100644
--- a/third_party/zlib/google/zip.cc
+++ b/third_party/zlib/google/zip.cc
@@ -95,12 +95,13 @@ namespace zip {
bool Unzip(const base::FilePath& src_file, const base::FilePath& dest_dir) {
return UnzipWithFilterCallback(src_file, dest_dir,
- base::Bind(&ExcludeNoFilesFilter));
+ base::Bind(&ExcludeNoFilesFilter), true);
}
bool UnzipWithFilterCallback(const base::FilePath& src_file,
const base::FilePath& dest_dir,
- const FilterCallback& filter_cb) {
+ const FilterCallback& filter_cb,
+ bool log_skipped_files) {
ZipReader reader;
if (!reader.Open(src_file)) {
DLOG(WARNING) << "Failed to open " << src_file.value();
@@ -122,7 +123,7 @@ bool UnzipWithFilterCallback(const base::FilePath& src_file,
<< reader.current_entry_info()->file_path().value();
return false;
}
- } else {
+ } else if (log_skipped_files) {
DLOG(WARNING) << "Skipped file "
<< reader.current_entry_info()->file_path().value();
}
« no previous file with comments | « third_party/zlib/google/zip.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698