Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2523673005: Enable strong-mode for pkg/kernel and fix some strong-mode warnings. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable strong-mode for pkg/kernel and fix some strong-mode warnings. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/kernel/commit/d056236180e3958a6d7eb5166f7a60a10085c988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M pkg/kernel/.analysis_options View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/bin/dartk.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/kernel/lib/transformations/continuation.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M pkg/kernel/test/batch_consistency.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/kernel/test/type_parser.dart View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years ago (2016-11-23 14:52:14 UTC) #2
Kevin Millikin (Google)
LGTM.
4 years ago (2016-11-23 14:54:43 UTC) #3
asgerf
4 years ago (2016-11-23 15:16:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d056236180e3958a6d7eb5166f7a60a10085c988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698