Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: pkg/kernel/test/batch_consistency.dart

Issue 2523673005: Enable strong-mode for pkg/kernel and fix some strong-mode warnings. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/transformations/continuation.dart ('k') | pkg/kernel/test/type_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/test/batch_consistency.dart
diff --git a/pkg/kernel/test/batch_consistency.dart b/pkg/kernel/test/batch_consistency.dart
index 3d0bcc7d19d9fdb5e21d74775ac5ba148a71848f..7a098df139d97c19d869c4ec0e20ed8dd8141379 100644
--- a/pkg/kernel/test/batch_consistency.dart
+++ b/pkg/kernel/test/batch_consistency.dart
@@ -35,10 +35,8 @@ main(List<String> args) async {
}
Future<bool> areFilesEqual(String first, String second) async {
- List<List<int>> bytes = await Future.wait([
- new File(first).readAsBytes(),
- new File(second).readAsBytes()
- ]);
+ List<List<int>> bytes = await Future
+ .wait([new File(first).readAsBytes(), new File(second).readAsBytes()]);
if (bytes[0].length != bytes[1].length) return false;
for (int i = 0; i < bytes[0].length; ++i) {
if (bytes[0][i] != bytes[1][i]) return false;
@@ -58,7 +56,9 @@ testBatchModeConsistency(List<String> options, List<String> files) {
List results = [null, null];
bool failed = false;
for (int i = 0; i < 2; ++i) {
- var args = []..addAll(options)..addAll(['--out', outputFiles[i], file]);
+ var args = <String>[]
+ ..addAll(options)
+ ..addAll(['--out', outputFiles[i], file]);
var state = (i == 0) ? sharedState : new dartk.BatchModeState();
try {
// We run the two executions in a loop to ensure any stack traces
« no previous file with comments | « pkg/kernel/lib/transformations/continuation.dart ('k') | pkg/kernel/test/type_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698