Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2523603005: Don't show the remaining time for offline page downloads (Closed)

Created:
4 years ago by qinmin
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Don't show the remaining time for offline page downloads For offline page downloads, we don't know the remaining time. Just show the downloading string should be fine. BUG=665553 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2514603002 Cr-Commit-Position: refs/heads/master@{#433238} (cherry picked from commit ba84a485f4f812beb9631d22320a68939aaac15f) Committed: https://chromium.googlesource.com/chromium/src/+/fd6493d1cefd182cefa9f22d58534cf7ce00647b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years ago (2016-11-23 19:20:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd6493d1cefd182cefa9f22d58534cf7ce00647b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698