Issue 2523603005: Don't show the remaining time for offline page downloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2523603005: Don't show the remaining time for offline page downloads (Closed)

Created:
4 years ago by qinmin

Modified:
4 years ago

Reviewers:
gone

CC:
chromium-reviews, asanka, agrieve+watch_chromium.org

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Don't show the remaining time for offline page downloads For offline page downloads, we don't know the remaining time. Just show the downloading string should be fine. BUG=665553 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2514603002 Cr-Commit-Position: refs/heads/master@{#433238} (cherry picked from commit ba84a485f4f812beb9631d22320a68939aaac15f) Committed: https://chromium.googlesource.com/chromium/src/+/fd6493d1cefd182cefa9f22d58534cf7ce00647b

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

qinmin

4 years ago (2016-11-23 19:20:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fd6493d1cefd182cefa9f22d58534cf7ce00647b (presubmit successful).