Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2514603002: Don't show the remaining time for offline page downloads (Closed)

Created:
4 years, 1 month ago by qinmin
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show the remaining time for offline page downloads For offline page downloads, we don't know the remaining time. Just show the downloading string should be fine. BUG=665553 Committed: https://crrev.com/ba84a485f4f812beb9631d22320a68939aaac15f Cr-Commit-Position: refs/heads/master@{#433238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
qinmin
PTAL
4 years, 1 month ago (2016-11-17 23:05:37 UTC) #2
gone
lgtm
4 years, 1 month ago (2016-11-17 23:22:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514603002/1
4 years, 1 month ago (2016-11-17 23:35:37 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
4 years, 1 month ago (2016-11-18 01:45:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514603002/1
4 years, 1 month ago (2016-11-18 17:39:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 18:14:47 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 18:16:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba84a485f4f812beb9631d22320a68939aaac15f
Cr-Commit-Position: refs/heads/master@{#433238}

Powered by Google App Engine
This is Rietveld 408576698