Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2523473004: In test_parser, skip files with non-ascii tags, and emit an error. (Closed)

Created:
4 years ago by qyearsley
Modified:
4 years ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, dominicc (has gone to gerrit), Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In test_parser, skip files with non-ascii tags, and emit an error. I believe this would make the w3c test auto-importer skip some files that have non-ascii characters in tags. See latest failure: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7805. In that build, the importer is failing when looking at some file in web-platform-tests/domxpath/ which has non-ascii characters in tags. BUG=621599 Committed: https://crrev.com/db88ab19535414c5055426dc1a2658651f5ae80b Cr-Commit-Position: refs/heads/master@{#435326}

Patch Set 1 #

Patch Set 2 : l #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
qyearsley
4 years ago (2016-11-22 23:41:22 UTC) #3
jeffcarp
lgtm
4 years ago (2016-11-23 21:23:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523473004/20001
4 years ago (2016-11-30 16:52:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 17:56:41 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-30 18:02:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db88ab19535414c5055426dc1a2658651f5ae80b
Cr-Commit-Position: refs/heads/master@{#435326}

Powered by Google App Engine
This is Rietveld 408576698