Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py

Issue 2523473004: In test_parser, skip files with non-ascii tags, and emit an error. (Closed)
Patch Set: l Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py
index 36762d4c1f50dd4ea9ff627c6760672558f4af04..9d39db87907994398f500f6044c6162c0cdd2ca6 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py
@@ -57,6 +57,9 @@ class TestParser(object):
# FIXME: Figure out what to do if we can't parse the file.
_log.error("HTMLParseError: Failed to parse %s", filename)
doc = None
+ except UnicodeEncodeError:
+ _log.error("UnicodeEncodeError while reading %s", filename)
+ doc = None
else:
if self.filesystem.isdir(filename):
# FIXME: Figure out what is triggering this and what to do about it.
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698