Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2523463002:
[turbofan] Utilize String comparison feedback. (Closed)
|
Created:
4 years, 1 month ago by Benedikt Meurer Modified:
3 years, 10 months ago CC:
v8-reviews_googlegroups.com, rmcilroy Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Utilize String comparison feedback.
Make use of the previously introduced String feedback for compare
operations in TurboFan.
R=jarin@chromium.org
BUG=v8:5267, v8:5400
Committed: https://crrev.com/5d4253ecfb6ddcbbd7eb5654e728efa9559284a2
Cr-Original-Commit-Position: refs/heads/master@{#41163}
Review-Url: https://codereview.chromium.org/2523463002
Cr-Commit-Position: refs/heads/master@{#43211}
Committed: https://chromium.googlesource.com/v8/v8/+/22e129e9b4261255bd4e24f1c1518215e928ea86
Patch Set 1 #Patch Set 2 : REBASE #Messages
Total messages: 25 (16 generated)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Jaro: PTAL Ross: FYI
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/21 18:40:34, Benedikt Meurer wrote: > Jaro: PTAL > Ross: FYI lgtm.
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479795656850650, "parent_rev":
"130dbcb9b5918a876f6648692f6e854f6dd55310", "commit_rev":
"0d08dfb779cdbbb8240d7de6e38c7a1134c1376a"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Utilize String comparison feedback. Make use of the previously introduced String feedback for compare operations in TurboFan. R=jarin@chromium.org BUG=v8:5267,v8:5400 ========== to ========== [turbofan] Utilize String comparison feedback. Make use of the previously introduced String feedback for compare operations in TurboFan. R=jarin@chromium.org BUG=v8:5267,v8:5400 Committed: https://crrev.com/5d4253ecfb6ddcbbd7eb5654e728efa9559284a2 Cr-Commit-Position: refs/heads/master@{#41163} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5d4253ecfb6ddcbbd7eb5654e728efa9559284a2 Cr-Commit-Position: refs/heads/master@{#41163}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2531183003/ by rmcilroy@chromium.org. The reason for reverting is: Seems to regress speedometer on Ignition and doesn't cause any improvements elsewhere. BUG=chromium:668651.
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Utilize String comparison feedback. Make use of the previously introduced String feedback for compare operations in TurboFan. R=jarin@chromium.org BUG=v8:5267,v8:5400 Committed: https://crrev.com/5d4253ecfb6ddcbbd7eb5654e728efa9559284a2 Cr-Commit-Position: refs/heads/master@{#41163} ========== to ========== [turbofan] Utilize String comparison feedback. Make use of the previously introduced String feedback for compare operations in TurboFan. R=jarin@chromium.org BUG=v8:5267,v8:5400 Committed: https://crrev.com/5d4253ecfb6ddcbbd7eb5654e728efa9559284a2 Cr-Commit-Position: refs/heads/master@{#41163} ==========
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/2523463002/#ps20001 (title: "REBASE")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487165785393910,
"parent_rev": "63096bc89d674d6c97bdecdbdfbf98871d1825e0", "commit_rev":
"22e129e9b4261255bd4e24f1c1518215e928ea86"}
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Utilize String comparison feedback. Make use of the previously introduced String feedback for compare operations in TurboFan. R=jarin@chromium.org BUG=v8:5267,v8:5400 Committed: https://crrev.com/5d4253ecfb6ddcbbd7eb5654e728efa9559284a2 Cr-Commit-Position: refs/heads/master@{#41163} ========== to ========== [turbofan] Utilize String comparison feedback. Make use of the previously introduced String feedback for compare operations in TurboFan. R=jarin@chromium.org BUG=v8:5267,v8:5400 Committed: https://crrev.com/5d4253ecfb6ddcbbd7eb5654e728efa9559284a2 Cr-Original-Commit-Position: refs/heads/master@{#41163} Review-Url: https://codereview.chromium.org/2523463002 Cr-Commit-Position: refs/heads/master@{#43211} Committed: https://chromium.googlesource.com/v8/v8/+/22e129e9b4261255bd4e24f1c1518215e92... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/22e129e9b4261255bd4e24f1c1518215e92... |
