|
|
Chromium Code Reviews
DescriptionUse mojo [de]serialization for SkBitmap property type conversion.
Removes this separate [de]serialization pattern.
Expands support beyond RGBA 8888.
BUG=666864
TEST=Automated; crash cited in bug no longer repros.
R=tsepez@chromium.org,sky@chromium.org
TBR=reed@google.com
Committed: https://crrev.com/e7bfffb17dcf8df18e8ecf78cb7ab5de6fed3853
Cr-Commit-Position: refs/heads/master@{#433711}
Patch Set 1 #
Messages
Total messages: 32 (21 generated)
Description was changed from ========== Use mojo [de]serialization for SkBitmap property type conversion. BUG=666864 ========== to ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org ==========
msw@chromium.org changed reviewers: + sky@chromium.org, tsepez@chromium.org
Description was changed from ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org ========== to ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org ==========
msw@chromium.org changed reviewers: - sky@chromium.org
Hey Tom, please take a look; thanks!
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
sky@chromium.org changed reviewers: + sky@chromium.org
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org ========== to ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=tomhudson@chromium.org ==========
msw@chromium.org changed reviewers: + tomhudson@chromium.org
Description was changed from ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=tomhudson@chromium.org ========== to ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=tomhudson@google.com ==========
msw@chromium.org changed reviewers: + tomhudson@google.com - tomhudson@chromium.org
+TBR tomhudson@ for new dep on skia/public/interfaces
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479772851377100, "parent_rev":
"188e5052c9673fbf213dc1585d9b8cc3e0c6351a", "commit_rev":
"ac44cd4198d1eaee080e9b894af7183320d83e82"}
Message was sent while issue was closed.
Description was changed from ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=tomhudson@google.com ========== to ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=tomhudson@google.com ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=tomhudson@google.com ========== to ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=tomhudson@google.com Committed: https://crrev.com/e7bfffb17dcf8df18e8ecf78cb7ab5de6fed3853 Cr-Commit-Position: refs/heads/master@{#433711} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e7bfffb17dcf8df18e8ecf78cb7ab5de6fed3853 Cr-Commit-Position: refs/heads/master@{#433711}
Message was sent while issue was closed.
Sorry, I've left the Chrome team; please ask reed@ or hcm@ to find a reviewer.
Message was sent while issue was closed.
Description was changed from ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=tomhudson@google.com Committed: https://crrev.com/e7bfffb17dcf8df18e8ecf78cb7ab5de6fed3853 Cr-Commit-Position: refs/heads/master@{#433711} ========== to ========== Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=reed@google.com Committed: https://crrev.com/e7bfffb17dcf8df18e8ecf78cb7ab5de6fed3853 Cr-Commit-Position: refs/heads/master@{#433711} ==========
Message was sent while issue was closed.
msw@chromium.org changed reviewers: + reed@google.com - tomhudson@google.com
Message was sent while issue was closed.
On 2016/11/23 09:31:47, tomhudson wrote: > Sorry, I've left the Chrome team; please ask reed@ or hcm@ to find a reviewer. Mike Reed, please take a look or recommend a reviewer for DEPS changes, thanks. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
