Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2523433003: Use mojo [de]serialization for SkBitmap property type conversion. (Closed)

Created:
4 years, 1 month ago by msw
Modified:
4 years ago
Reviewers:
Tom Sepez, sky, reed1
CC:
chromium-reviews, rjkroege, sky
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use mojo [de]serialization for SkBitmap property type conversion. Removes this separate [de]serialization pattern. Expands support beyond RGBA 8888. BUG=666864 TEST=Automated; crash cited in bug no longer repros. R=tsepez@chromium.org,sky@chromium.org TBR=reed@google.com Committed: https://crrev.com/e7bfffb17dcf8df18e8ecf78cb7ab5de6fed3853 Cr-Commit-Position: refs/heads/master@{#433711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -143 lines) Patch
M services/ui/public/cpp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/public/cpp/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/public/cpp/property_type_converters.h View 2 chunks +0 lines, -4 lines 0 comments Download
M services/ui/public/cpp/property_type_converters.cc View 2 chunks +5 lines, -69 lines 0 comments Download
M services/ui/public/cpp/tests/property_type_converters_unittest.cc View 2 chunks +6 lines, -69 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
msw
Hey Tom, please take a look; thanks!
4 years, 1 month ago (2016-11-21 21:42:57 UTC) #5
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-21 21:50:59 UTC) #8
sky
LGTM
4 years, 1 month ago (2016-11-21 23:07:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523433003/1
4 years, 1 month ago (2016-11-21 23:44:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/309942)
4 years, 1 month ago (2016-11-21 23:52:41 UTC) #16
msw
+TBR tomhudson@ for new dep on skia/public/interfaces
4 years, 1 month ago (2016-11-22 00:00:45 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523433003/1
4 years, 1 month ago (2016-11-22 00:01:18 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 00:19:58 UTC) #26
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e7bfffb17dcf8df18e8ecf78cb7ab5de6fed3853 Cr-Commit-Position: refs/heads/master@{#433711}
4 years, 1 month ago (2016-11-22 00:27:31 UTC) #28
tomhudson
Sorry, I've left the Chrome team; please ask reed@ or hcm@ to find a reviewer.
4 years ago (2016-11-23 09:31:47 UTC) #29
msw
4 years ago (2016-11-23 16:57:31 UTC) #32
Message was sent while issue was closed.
On 2016/11/23 09:31:47, tomhudson wrote:
> Sorry, I've left the Chrome team; please ask reed@ or hcm@ to find a reviewer.

Mike Reed, please take a look or recommend a reviewer for DEPS changes, thanks.

Powered by Google App Engine
This is Rietveld 408576698