Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: services/ui/public/cpp/property_type_converters.h

Issue 2523433003: Use mojo [de]serialization for SkBitmap property type conversion. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/public/cpp/DEPS ('k') | services/ui/public/cpp/property_type_converters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/public/cpp/property_type_converters.h
diff --git a/services/ui/public/cpp/property_type_converters.h b/services/ui/public/cpp/property_type_converters.h
index 481dc147a954ed1efbc337202ab092fd23405ce5..0d8ee73d2ba3f6c71c61db3b211d360a9b7160e2 100644
--- a/services/ui/public/cpp/property_type_converters.h
+++ b/services/ui/public/cpp/property_type_converters.h
@@ -23,8 +23,6 @@ namespace mojo {
// TODO(beng): these methods serialize types used for standard properties
// to vectors of bytes used by Window::SetSharedProperty().
// replace this with serialization code generated @ bindings.
-// This would be especially useful for SkBitmap, which could be
-// replaced with the skia.Bitmap mojom struct serialization.
template <>
struct TypeConverter<std::vector<uint8_t>, gfx::Rect> {
@@ -80,8 +78,6 @@ struct TypeConverter<std::string, std::vector<uint8_t>> {
static std::string Convert(const std::vector<uint8_t>& input);
};
-// NOTE: These methods only serialize and deserialize the common case of RGBA
-// 8888 bitmaps with premultiplied alpha.
template <>
struct TypeConverter<std::vector<uint8_t>, SkBitmap> {
static std::vector<uint8_t> Convert(const SkBitmap& input);
« no previous file with comments | « services/ui/public/cpp/DEPS ('k') | services/ui/public/cpp/property_type_converters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698