Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1994)

Unified Diff: appengine/findit/model/crash/fracas_crash_analysis.py

Issue 2523343002: [Predator] Refactor ToPublishResult and fix keyerror 'found' (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/crash/fracas_crash_analysis.py
diff --git a/appengine/findit/model/crash/fracas_crash_analysis.py b/appengine/findit/model/crash/fracas_crash_analysis.py
index 2e0bf9554d72033b9eb0706a9eb5f90d40935347..1f2e1e619bb453dab9f54212424d66051fa7aef9 100644
--- a/appengine/findit/model/crash/fracas_crash_analysis.py
+++ b/appengine/findit/model/crash/fracas_crash_analysis.py
@@ -4,9 +4,17 @@
from google.appengine.ext import ndb
+from common import appengine_util
from model.crash.chrome_crash_analysis import ChromeCrashAnalysis
+FRACAS_FEEDBACK_URL_TEMPLATE = '%s/crash/fracas-result-feedback?key=%s'
stgao 2016/11/23 23:51:14 See question above.
Sharu Jiang 2016/11/24 00:13:38 As above.
+
class FracasCrashAnalysis(ChromeCrashAnalysis):
"""Represents an analysis of a Chrome crash on Fracas."""
- pass
+
+ def ProcessResultForPublishing(self, result):
+ """Fracas specific processing of result data for publishing."""
+ result['feedback_url'] = FRACAS_FEEDBACK_URL_TEMPLATE % (
+ appengine_util.GetDefaultVersionHostname(), self.key.urlsafe())
+ return result

Powered by Google App Engine
This is Rietveld 408576698