appengine/findit/model/crash/fracas_crash_analysis.py - Issue 2523343002: [Predator] Refactor ToPublishResult and fix keyerror 'found'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/model/crash/fracas_crash_analysis.py

Issue 2523343002: [Predator] Refactor ToPublishResult and fix keyerror 'found' (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from google.appengine.ext import ndb	5 from google.appengine.ext import ndb

6	6

	7 from common import appengine_util

7 from model.crash.chrome_crash_analysis import ChromeCrashAnalysis	8 from model.crash.chrome_crash_analysis import ChromeCrashAnalysis

8	9

	10 FRACAS_FEEDBACK_URL_TEMPLATE = '%s/crash/fracas-result-feedback?key=%s'
	stgao 2016/11/23 23:51:14 See question above. See question above. Sharu Jiang 2016/11/24 00:13:38 As above. Show quoted text On 2016/11/23 23:51:14, stgao (slow on Monday) wrote: > See question above. As above.
	11

9	12

10 class FracasCrashAnalysis(ChromeCrashAnalysis):	13 class FracasCrashAnalysis(ChromeCrashAnalysis):

11 """Represents an analysis of a Chrome crash on Fracas."""	14 """Represents an analysis of a Chrome crash on Fracas."""

12 pass	15

	16 def ProcessResultForPublishing(self, result):

	17 """Fracas specific processing of result data for publishing."""

	18 result['feedback_url'] = FRACAS_FEEDBACK_URL_TEMPLATE % (

	19 appengine_util.GetDefaultVersionHostname(), self.key.urlsafe())

	20 return result

OLD	NEW