Implement rewind: drop one or more frames from the debugger.

Implement rewind: drop one or more frames from the debugger.

Not yet implemented on dbc.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/af1875be910a24f34f1983b314f45c1ecd8097ad

[turnidge, 2016-11-22 22:13:55]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-11-22 22:27:51]

LGTM wC

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/debugger.dart:2346: List frameElements =
_frameList.children;
can we not just call clear on the lists?

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:1350: reloading = true;
why are we tracking this reloading bit?

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/service.status (right):

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/service.status:66: rewind_test: RuntimeError #
Rewind not implemented.
simdbc is important for Flutter development is there a bug # to reference for
dbc support?

https://codereview.chromium.org/2523053002/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/2523053002/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:1335: *error = Thread::Current()->zone()->PrintToString(
you could just assign error directly here and below.

[turnidge, 2016-11-22 22:54:06]

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/debugger.dart:2346: List frameElements =
_frameList.children;
On 2016/11/22 22:27:50, Cutch wrote:
> can we not just call clear on the lists?

Turns out this code was dead.  Removed.

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:1350: reloading = true;
On 2016/11/22 22:27:50, Cutch wrote:
> why are we tracking this reloading bit?

Perhaps we were going to use it to track isolate status back when reloading was
asynchronous.  But it doesn't seem to be used for anything right now.  Removing.

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/service.status (right):

https://codereview.chromium.org/2523053002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/service.status:66: rewind_test: RuntimeError #
Rewind not implemented.
On 2016/11/22 22:27:50, Cutch wrote:
> simdbc is important for Flutter development is there a bug # to reference for
> dbc support?

Added a tracking bug.

https://codereview.chromium.org/2523053002/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/2523053002/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:1335: *error = Thread::Current()->zone()->PrintToString(
On 2016/11/22 22:27:50, Cutch wrote:
> you could just assign error directly here and below.

Ok, fixed.

[Cutch, 2016-11-22 22:54:39]

lgtm

[turnidge, 2016-11-22 23:26:13]

Description was changed from

==========
Implement rewind: drop one or more frames from the debugger.

Not yet implemented on dbc.

BUG=
==========

to

==========
Implement rewind: drop one or more frames from the debugger.

Not yet implemented on dbc.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/af1875be910a24f34f1983b314f45c1ecd8097ad
==========

[turnidge, 2016-11-22 23:26:14]

Committed patchset #3 (id:40001) manually as
af1875be910a24f34f1983b314f45c1ecd8097ad (presubmit successful).