Issue 2523023002: M55: Invalidate a slightly larger rect when updating popup annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2523023002: M55: Invalidate a slightly larger rect when updating popup annotations. (Closed)

Created:
4 years, 1 month ago by Lei Zhang

Modified:
4 years, 1 month ago

Reviewers:

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/chromium/2883

Project:
pdfium

Visibility:
Public.

M55: Invalidate a slightly larger rect when updating popup annotations. It looks like sometimes there are rounding errors in the display pipeline when displaying / hiding popup annotations. Compensate by rouding up the damaged rect slightly. BUG=chromium:662804 Review-Url: https://codereview.chromium.org/2492733002 (cherry picked from commit c75dcd253d75ea93608410d90a3ce1b605590af0) Committed: https://pdfium.googlesource.com/pdfium/+/dad0707d0e7ea3f612dd14a5e35b5af163cedf82

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	fpdfsdk/cpdfsdk_baannothandler.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Lei Zhang

4 years, 1 month ago (2016-11-22 21:36:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dad0707d0e7ea3f612dd14a5e35b5af163cedf82 (presubmit successful).