Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2492733002: Invalidate a slightly larger rect when updating popup annotations. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Invalidate a slightly larger rect when updating popup annotations. It looks like sometimes there are rounding errors in the display pipeline when displaying / hiding popup annotations. Compensate by rouding up the damaged rect slightly. BUG=chromium:662804 Committed: https://pdfium.googlesource.com/pdfium/+/c75dcd253d75ea93608410d90a3ce1b605590af0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M fpdfsdk/cpdfsdk_baannothandler.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
Aww, I forgot to send this one out.
4 years, 1 month ago (2016-11-14 20:13:54 UTC) #6
dsinclair
lgtm
4 years, 1 month ago (2016-11-14 20:58:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492733002/1
4 years, 1 month ago (2016-11-14 20:59:02 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 21:15:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c75dcd253d75ea93608410d90a3ce1b60559...

Powered by Google App Engine
This is Rietveld 408576698