third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html - Issue 2522923003: Reference table row via the cell for row background display item client.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html

Issue 2522923003: Reference table row via the cell for row background display item client. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../resources/run-after-layout-and-paint.js"></script>

	3 <!-- Test passes if it does not crash on an ASAN build. -->

	4 <style>

	5 .c7 { background: white; direction: rtl; }

	6 .c7[class*="c7"] { display: table-column-group; }

	7 .c13 { display: table-cell; border-style: ridge; will-change: transform; }
	Xianzhu 2016/11/23 00:56:25 Are all of the CSS properties necessary for reprod Are all of the CSS properties necessary for reproducing the bug? wkorman 2016/11/23 02:05:22 I spent time taking some out, I was able to pull a Show quoted text On 2016/11/23 00:56:25, Xianzhu wrote: > Are all of the CSS properties necessary for reproducing the bug? I spent time taking some out, I was able to pull a few more on re-review and fixed formatting too.
	8 </style>

	9 <script>

	10 var nodes = Array();

	11 nodes[1] = document.createElement('label');

	12 nodes[1].setAttribute('class', 'c13');

	13 document.documentElement.appendChild(nodes[1]);

	14 nodes[2] = document.createElement('colgroup');

	15 nodes[2].setAttribute('class', 'c13');

	16 document.documentElement.appendChild(nodes[2]);

	17 nodes[3] = document.createElement('aside');

	18 nodes[3].setAttribute('class', 'c13');

	19 document.documentElement.appendChild(nodes[3]);
	Xianzhu 2016/11/23 00:56:25 Can the script be replaced with direct HTML? Can the script be replaced with direct HTML? wkorman 2016/11/23 02:05:22 Have tried a number of ways without success. Main Show quoted text On 2016/11/23 00:56:25, Xianzhu wrote: > Can the script be replaced with direct HTML? Have tried a number of ways without success. Main challenge is adding the colgroup in a declarative manner that still allows referencing it via script to fiddle its class. Can do it if I wrap it in an explicit table, but then issue doesn't repro for some reason. Spent enough time to deem not worth further. Conceptually we should be able to create a failing test case since we thoroughly understand situation, it's just spending the time. Can pursue further if you think warranted.
	20 if (window.testRunner)

	21 testRunner.waitUntilDone();

	22 runAfterLayoutAndPaint(function() {

	23 nodes[2].setAttribute('class', 'c11');

	24 nodes[1].setAttribute('class', 'c7');
	Xianzhu 2016/11/23 00:56:25 Please replace nodes[<n>] and c<n> with meaningful Please replace nodes[<n>] and c<n> with meaningful names. wkorman 2016/11/23 02:05:22 Done. Show quoted text On 2016/11/23 00:56:25, Xianzhu wrote: > Please replace nodes[<n>] and c<n> with meaningful names. Done.
	25 }, true);

	26 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup-expected.html » ('j') | no next file with comments »