Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 25229002: Report MissingCompileTime errors on the VM, status file updates for the remaining issues (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index b93c3ded81b21e9304d1674231de225354a8ef46..0a2e31f0b87ace1f4a8eeac8f432a85349e6eec0 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1154,14 +1154,6 @@ class VmCommandOutputImpl extends CommandOutputImpl
return Expectation.PASS;
}
- // We're not as strict, if the exitCode indicated an uncaught exception
- // we say it passed nonetheless
- // TODO(kustermann): As soon as the VM team makes sure we get correct
- // exit codes, we should remove this.
- if (exitCode == DART_VM_EXITCODE_UNCAUGHT_EXCEPTION) {
- return Expectation.PASS;
- }
-
return Expectation.MISSING_COMPILETIME_ERROR;
}
if (testCase.info.hasRuntimeError) {
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698