Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 25229002: Report MissingCompileTime errors on the VM, status file updates for the remaining issues (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1136 matching lines...) Expand 10 before | Expand all | Expand 10 after
1147 if (hasCrashed) return Expectation.CRASH; 1147 if (hasCrashed) return Expectation.CRASH;
1148 if (hasTimedOut) return Expectation.TIMEOUT; 1148 if (hasTimedOut) return Expectation.TIMEOUT;
1149 1149
1150 // Multitests are handled specially 1150 // Multitests are handled specially
1151 if (testCase.info != null) { 1151 if (testCase.info != null) {
1152 if (testCase.info.hasCompileError) { 1152 if (testCase.info.hasCompileError) {
1153 if (exitCode == DART_VM_EXITCODE_COMPILE_TIME_ERROR) { 1153 if (exitCode == DART_VM_EXITCODE_COMPILE_TIME_ERROR) {
1154 return Expectation.PASS; 1154 return Expectation.PASS;
1155 } 1155 }
1156 1156
1157 // We're not as strict, if the exitCode indicated an uncaught exception
1158 // we say it passed nonetheless
1159 // TODO(kustermann): As soon as the VM team makes sure we get correct
1160 // exit codes, we should remove this.
1161 if (exitCode == DART_VM_EXITCODE_UNCAUGHT_EXCEPTION) {
1162 return Expectation.PASS;
1163 }
1164
1165 return Expectation.MISSING_COMPILETIME_ERROR; 1157 return Expectation.MISSING_COMPILETIME_ERROR;
1166 } 1158 }
1167 if (testCase.info.hasRuntimeError) { 1159 if (testCase.info.hasRuntimeError) {
1168 // TODO(kustermann): Do we consider a "runtimeError" only an uncaught 1160 // TODO(kustermann): Do we consider a "runtimeError" only an uncaught
1169 // exception or does any nonzero exit code fullfil this requirement? 1161 // exception or does any nonzero exit code fullfil this requirement?
1170 if (exitCode != 0) { 1162 if (exitCode != 0) {
1171 return Expectation.PASS; 1163 return Expectation.PASS;
1172 } 1164 }
1173 return Expectation.MISSING_RUNTIME_ERROR; 1165 return Expectation.MISSING_RUNTIME_ERROR;
1174 } 1166 }
(...skipping 1206 matching lines...) Expand 10 before | Expand all | Expand 10 after
2381 } 2373 }
2382 } 2374 }
2383 2375
2384 void eventAllTestsDone() { 2376 void eventAllTestsDone() {
2385 for (var listener in _eventListener) { 2377 for (var listener in _eventListener) {
2386 listener.allDone(); 2378 listener.allDone();
2387 } 2379 }
2388 _allDone(); 2380 _allDone();
2389 } 2381 }
2390 } 2382 }
OLDNEW
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698