Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2522823002: Blink Animation: Rename AnimationStack to EffectStack. (Closed)

Created:
4 years, 1 month ago by loyso (OOO)
Modified:
4 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Animation: Rename AnimationStack to EffectStack. BUG=624640 Committed: https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357 Cr-Commit-Position: refs/heads/master@{#434045}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename getter and data (and locals) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -579 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/animation/AnimationStack.h View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/Source/core/animation/AnimationStack.cpp View 1 chunk +0 lines, -181 lines 0 comments Download
D third_party/WebKit/Source/core/animation/AnimationStackTest.cpp View 1 chunk +0 lines, -222 lines 0 comments Download
M third_party/WebKit/Source/core/animation/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/EffectStack.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/EffectStack.cpp View 1 7 chunks +17 lines, -17 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/EffectStackTest.cpp View 1 12 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimations.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimations.cpp View 1 2 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
loyso (OOO)
4 years, 1 month ago (2016-11-22 05:43:57 UTC) #4
loyso (OOO)
sashab@, core/svg/SVGElement.cpp and core/BUILD.gn please! alancutter@, core/animation/ please!
4 years, 1 month ago (2016-11-22 05:45:06 UTC) #6
loyso (OOO)
https://codereview.chromium.org/2522823002/diff/1/third_party/WebKit/Source/core/animation/ElementAnimations.h File third_party/WebKit/Source/core/animation/ElementAnimations.h (right): https://codereview.chromium.org/2522823002/diff/1/third_party/WebKit/Source/core/animation/ElementAnimations.h#newcode58 third_party/WebKit/Source/core/animation/ElementAnimations.h:58: EffectStack& animationStack() { return m_animationStack; } Hmm. We need ...
4 years, 1 month ago (2016-11-22 05:46:17 UTC) #7
loyso (OOO)
https://codereview.chromium.org/2522823002/diff/1/third_party/WebKit/Source/core/animation/ElementAnimations.h File third_party/WebKit/Source/core/animation/ElementAnimations.h (right): https://codereview.chromium.org/2522823002/diff/1/third_party/WebKit/Source/core/animation/ElementAnimations.h#newcode58 third_party/WebKit/Source/core/animation/ElementAnimations.h:58: EffectStack& animationStack() { return m_animationStack; } On 2016/11/22 05:46:17, ...
4 years, 1 month ago (2016-11-22 05:58:23 UTC) #8
sashab
core/svg/SVGElement.cpp and core/BUILD.gn LGTM
4 years, 1 month ago (2016-11-22 23:41:51 UTC) #13
alancutter (OOO until 2018)
lgtm
4 years, 1 month ago (2016-11-22 23:44:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522823002/20001
4 years, 1 month ago (2016-11-22 23:48:07 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-23 00:54:02 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 00:56:23 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357
Cr-Commit-Position: refs/heads/master@{#434045}

Powered by Google App Engine
This is Rietveld 408576698