DevTools: [Persistence] properly copy breakpoints to filesystem during reload

DevTools: [Persistence] properly copy breakpoints to filesystem during reload

Persitence takes care of synchronizing breakpoints between filesystem and
network files:
- when the PersistenceBinding comes, breakpoints are moved from fileSystem
  to Network uiSourceCode
- when the PersistenceBinding gets removed, breakpoints are copied
  from Network uiSourcecode to filesystem

Problem:
  When the network uiSourceCode gets removed (e.g. page reload happened),
  the breakpoint manager cleans up all breakpoints associated with this
  UISourceCode.
  As a result, persistence fails to copy breakpoints over to the filesystem.

This patch starts using breakpointsForURL to set breakpoints on FileSystem
UISourceCode.

BUG=649837
R=dgozman

Committed: https://crrev.com/6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af
Cr-Commit-Position: refs/heads/master@{#434017}

[lushnikov, 2016-11-22 02:50:03]

please, take a look

[lushnikov, 2016-11-22 02:50:08]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 02:50:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 04:49:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 04:49:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-11-22 21:24:32]

lgtm

[lushnikov, 2016-11-22 21:38:16]

thanks!

[lushnikov, 2016-11-22 21:38:19]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-22 21:38:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2522753002/#ps20001
(title: "fix test")

[commit-bot: I haz the power, 2016-11-22 21:39:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 23:17:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479850699734380,
"parent_rev": "9a30bddebae8f7636c23dd2ac24cf8a79cf33ae4", "commit_rev":
"7ad8cf5580951e860edf933e26b115647c36d624"}

[commit-bot: I haz the power, 2016-11-22 23:18:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-22 23:20:40]

Description was changed from

==========
DevTools: [Persistence] properly copy breakpoints to filesystem during reload

Persitence takes care of synchronizing breakpoints between filesystem and
network files:
- when the PersistenceBinding comes, breakpoints are moved from fileSystem
  to Network uiSourceCode
- when the PersistenceBinding gets removed, breakpoints are copied
  from Network uiSourcecode to filesystem

Problem:
  When the network uiSourceCode gets removed (e.g. page reload happened),
  the breakpoint manager cleans up all breakpoints associated with this
  UISourceCode.
  As a result, persistence fails to copy breakpoints over to the filesystem.

This patch starts using breakpointsForURL to set breakpoints on FileSystem
UISourceCode.

BUG=649837
R=dgozman
==========

to

==========
DevTools: [Persistence] properly copy breakpoints to filesystem during reload

Persitence takes care of synchronizing breakpoints between filesystem and
network files:
- when the PersistenceBinding comes, breakpoints are moved from fileSystem
  to Network uiSourceCode
- when the PersistenceBinding gets removed, breakpoints are copied
  from Network uiSourcecode to filesystem

Problem:
  When the network uiSourceCode gets removed (e.g. page reload happened),
  the breakpoint manager cleans up all breakpoints associated with this
  UISourceCode.
  As a result, persistence fails to copy breakpoints over to the filesystem.

This patch starts using breakpointsForURL to set breakpoints on FileSystem
UISourceCode.

BUG=649837
R=dgozman

Committed: https://crrev.com/6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af
Cr-Commit-Position: refs/heads/master@{#434017}
==========

[commit-bot: I haz the power, 2016-11-22 23:20:41]

Patchset 2 (id:??) landed as
https://crrev.com/6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af
Cr-Commit-Position: refs/heads/master@{#434017}