Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

Issue 2522753002: DevTools: [Persistence] properly copy breakpoints to filesystem during reload (Closed)
Patch Set: fix test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
diff --git a/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js b/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
index 9fc05e0b2f7b4a4acf2b92de6b4122b406e4aa06..3434b971d435adf9d75b8b55f1f4061ed8e9b4e5 100644
--- a/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
+++ b/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
@@ -73,7 +73,7 @@ Persistence.Persistence = class extends Common.Object {
this._removeFilePathBindingPrefixes(binding.fileSystem.url());
- this._copyBreakpoints(binding.network, binding.fileSystem);
+ this._breakpointManager.copyBreakpoints(binding.network.url(), binding.fileSystem);
this.dispatchEventToListeners(Persistence.Persistence.Events.BindingRemoved, binding);
}
@@ -144,18 +144,6 @@ Persistence.Persistence = class extends Common.Object {
}
/**
- * @param {!Workspace.UISourceCode} from
- * @param {!Workspace.UISourceCode} to
- */
- _copyBreakpoints(from, to) {
- var breakpoints = this._breakpointManager.breakpointsForUISourceCode(from);
- for (var breakpoint of breakpoints) {
- this._breakpointManager.setBreakpoint(
- to, breakpoint.lineNumber(), breakpoint.columnNumber(), breakpoint.condition(), breakpoint.enabled());
- }
- }
-
- /**
* @param {!Workspace.UISourceCode} uiSourceCode
* @return {boolean}
*/
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698